You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm the author of pevents, the WIN32 manual/auto-reset events library for Linux. To my knowledge, VS Code is (or was) one of the bigger projects depending on pevents; iirc it was used in some of the language-specific extensions.
There's a fairly large change that's been finalized and is ready for merging into master that improves the determinism of the API on non-Windows hosts to match the Win32 behavior, but I was wondering if someone from the team working on the extensions that use pevents could get in touch. Presumably your project has some LSP unit/integration tests that cover multithreaded synchronization; it would be great if I could get an all-ok that everything continues to work fine with the latest changes. Given the nature of multithreaded code (especially with optimizations enabled) it's extremely tricky to validate architectural changes to synchronization primitives, even with all the unit and regression tests passing on our end. Having further real-world verification would be great, and in case any issues arise, hopefully it would be better than you guys updating to master and having your production release randomly fail.
Hi @mqudsi . I don't believe the C/C++ extension currently makes use of pevents. It had been used at one time, in an area of the code that has since been refactored. I no longer see any sign of pevents or neosmart use in our native codebase.
Thanks so much for your efforts. I'm sorry we can't be of more help.
Hello team,
I'm the author of pevents, the WIN32 manual/auto-reset events library for Linux. To my knowledge, VS Code is (or was) one of the bigger projects depending on pevents; iirc it was used in some of the language-specific extensions.
There's a fairly large change that's been finalized and is ready for merging into master that improves the determinism of the API on non-Windows hosts to match the Win32 behavior, but I was wondering if someone from the team working on the extensions that use pevents could get in touch. Presumably your project has some LSP unit/integration tests that cover multithreaded synchronization; it would be great if I could get an all-ok that everything continues to work fine with the latest changes. Given the nature of multithreaded code (especially with optimizations enabled) it's extremely tricky to validate architectural changes to synchronization primitives, even with all the unit and regression tests passing on our end. Having further real-world verification would be great, and in case any issues arise, hopefully it would be better than you guys updating to master and having your production release randomly fail.
(This request previous incorrectly filed under the main VSCode project.)
The text was updated successfully, but these errors were encountered: