Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream pevents changes, early testing or feedback requested #8582

Closed
mqudsi opened this issue Dec 17, 2021 · 2 comments
Closed

Upstream pevents changes, early testing or feedback requested #8582

mqudsi opened this issue Dec 17, 2021 · 2 comments

Comments

@mqudsi
Copy link

mqudsi commented Dec 17, 2021

Hello team,

I'm the author of pevents, the WIN32 manual/auto-reset events library for Linux. To my knowledge, VS Code is (or was) one of the bigger projects depending on pevents; iirc it was used in some of the language-specific extensions.

There's a fairly large change that's been finalized and is ready for merging into master that improves the determinism of the API on non-Windows hosts to match the Win32 behavior, but I was wondering if someone from the team working on the extensions that use pevents could get in touch. Presumably your project has some LSP unit/integration tests that cover multithreaded synchronization; it would be great if I could get an all-ok that everything continues to work fine with the latest changes. Given the nature of multithreaded code (especially with optimizations enabled) it's extremely tricky to validate architectural changes to synchronization primitives, even with all the unit and regression tests passing on our end. Having further real-world verification would be great, and in case any issues arise, hopefully it would be better than you guys updating to master and having your production release randomly fail.

(This request previous incorrectly filed under the main VSCode project.)

@Colengms
Copy link
Collaborator

Hi @mqudsi . I don't believe the C/C++ extension currently makes use of pevents. It had been used at one time, in an area of the code that has since been refactored. I no longer see any sign of pevents or neosmart use in our native codebase.

Thanks so much for your efforts. I'm sorry we can't be of more help.

@mqudsi
Copy link
Author

mqudsi commented Dec 19, 2021

Thanks for clarifying, @Colengms.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants