Skip to content

Commit 085a839

Browse files
authored
Address codeQL issues (#15724)
1 parent b519e0a commit 085a839

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

src/test/datascience/jupyterServer.node.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,7 @@ export class JupyterServer {
410410
}
411411

412412
function generateHashedPassword(password: string) {
413-
const hash = crypto.createHash('sha1');
413+
const hash = crypto.createHash('sha1'); // CodeQL [SM04514] This is used only in tests and not in production. Also this is a requirement of the Jupyter Application (out of our control).
414414
const salt = genRandomString(16);
415415
hash.update(password); // CodeQL [SM01511] This password is hashed as per the requirements of Jupyter Server application, it is only used in tests (to launch a password protected jupyter server) and not production.
416416
hash.update(salt);

src/webviews/webview-side/data-explorer/globalJQueryImports.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ After that we need to load slickgrid, and then the jQuery plugin from slickgrid
1212
// use slickgridJQ instead of the usual $ to make it clear that we need that JQ and not
1313
// the one currently in node-modules
1414

15-
// eslint-disable-next-line @typescript-eslint/no-var-requires, @typescript-eslint/no-require-imports
1615
require('slickgrid/lib/jquery-1.11.2.min');
1716

18-
// eslint-disable-next-line @typescript-eslint/no-var-requires, @typescript-eslint/no-require-imports
1917
require('slickgrid/lib/jquery.event.drag-2.3.0');

0 commit comments

Comments
 (0)