Skip to content

Commit 11f3c67

Browse files
authored
Disable warning about Python version (#15238)
1 parent af83162 commit 11f3c67

File tree

1 file changed

+19
-23
lines changed

1 file changed

+19
-23
lines changed

src/notebooks/controllers/vscodeNotebookController.ts

Lines changed: 19 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ import {
3737
IExtensionContext
3838
} from '../../platform/common/types';
3939
import { createDeferred } from '../../platform/common/utils/async';
40-
import { DataScience, Common } from '../../platform/common/utils/localize';
4140
import { noop, swallowExceptions } from '../../platform/common/utils/misc';
4241
import { sendKernelTelemetryEvent } from '../../kernels/telemetry/sendKernelTelemetryEvent';
4342
import { IServiceContainer } from '../../platform/ioc/types';
@@ -81,11 +80,9 @@ import { LastCellExecutionTracker } from '../../kernels/execution/lastCellExecut
8180
import type { IAnyMessageArgs } from '@jupyterlab/services/lib/kernel/kernel';
8281
import { getParentHeaderMsgId } from '../../kernels/execution/cellExecutionMessageHandler';
8382
import { DisposableStore } from '../../platform/common/utils/lifecycle';
84-
import { openInBrowser } from '../../platform/common/net/browser';
8583
import { KernelError } from '../../kernels/errors/kernelError';
8684
import { JupyterVariablesProvider } from '../../kernels/variables/JupyterVariablesProvider';
8785
import { IJupyterVariables } from '../../kernels/variables/types';
88-
import { getVersion } from '../../platform/interpreter/helpers';
8986

9087
/**
9188
* Our implementation of the VSCode Notebook Controller. Called by VS code to execute cells in a notebook. Also displayed
@@ -390,26 +387,25 @@ export class VSCodeNotebookController implements Disposable, IVSCodeNotebookCont
390387
await Promise.all(cells.map((cell) => this.executeCell(notebook, cell)));
391388
}
392389
private async warnWhenUsingOutdatedPython() {
393-
const pyVersion = await getVersion(this.kernelConnection.interpreter);
394-
if (
395-
!pyVersion ||
396-
(pyVersion.major || 0) >= 4 ||
397-
(this.kernelConnection.kind !== 'startUsingLocalKernelSpec' &&
398-
this.kernelConnection.kind !== 'startUsingPythonInterpreter')
399-
) {
400-
return;
401-
}
402-
403-
if ((pyVersion.major || 0) < 3 || (pyVersion.major === 3 && (pyVersion.minor || 0) <= 5)) {
404-
window
405-
.showWarningMessage(DataScience.warnWhenSelectingKernelWithUnSupportedPythonVersion, Common.learnMore)
406-
.then((selection) => {
407-
if (selection !== Common.learnMore) {
408-
return;
409-
}
410-
return openInBrowser('https://aka.ms/jupyterUnSupportedPythonKernelVersions');
411-
}, noop);
412-
}
390+
// const pyVersion = await getVersion(this.kernelConnection.interpreter);
391+
// if (
392+
// !pyVersion ||
393+
// (pyVersion.major || 0) >= 4 ||
394+
// (this.kernelConnection.kind !== 'startUsingLocalKernelSpec' &&
395+
// this.kernelConnection.kind !== 'startUsingPythonInterpreter')
396+
// ) {
397+
// return;
398+
// }
399+
// if ((pyVersion.major || 0) < 3 || (pyVersion.major === 3 && (pyVersion.minor || 0) <= 5)) {
400+
// window
401+
// .showWarningMessage(DataScience.warnWhenSelectingKernelWithUnSupportedPythonVersion, Common.learnMore)
402+
// .then((selection) => {
403+
// if (selection !== Common.learnMore) {
404+
// return;
405+
// }
406+
// return openInBrowser('https://aka.ms/jupyterUnSupportedPythonKernelVersions');
407+
// }, noop);
408+
// }
413409
}
414410
private async onDidChangeSelectedNotebooks(event: { notebook: NotebookDocument; selected: boolean }) {
415411
traceInfoIfCI(

0 commit comments

Comments
 (0)