Skip to content

Commit 5898fbc

Browse files
CopilotDonJayamanne
andcommitted
Fix integration test to properly call both shutdown() and dispose() methods
Co-authored-by: DonJayamanne <[email protected]>
1 parent 1eaee5b commit 5898fbc

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

src/test/datascience/notebook/interruptRestart.vscode.test.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -528,14 +528,18 @@ suite('Restart/Interrupt/Cancel/Errors @kernelCore', function () {
528528
logger.info('Step 2: Shutdown kernel');
529529
await kernel.shutdown();
530530

531-
// After shutdown, the kernel should be disposed
531+
// Then dispose the kernel
532+
logger.info('Step 3: Dispose kernel');
533+
await kernel.dispose();
534+
535+
// After shutdown and disposal, the kernel should be disposed
532536
await waitForCondition(
533537
async () => kernel.disposed,
534538
30_000,
535-
'Kernel should be disposed after shutdown'
539+
'Kernel should be disposed after shutdown and disposal'
536540
);
537541

538-
logger.info('Step 3: Verify kernel is disposed');
539-
assert.isTrue(kernel.disposed, 'Kernel should be disposed after shutdown');
542+
logger.info('Step 4: Verify kernel is disposed');
543+
assert.isTrue(kernel.disposed, 'Kernel should be disposed after shutdown and disposal');
540544
});
541545
});

0 commit comments

Comments
 (0)