Skip to content

Commit 778c18c

Browse files
authored
Update install button label (#16284)
1 parent 2cb7164 commit 778c18c

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

src/notebooks/controllers/commands/installPythonControllerCommands.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,12 @@ export class InstallPythonControllerCommands implements IExtensionSyncActivation
4848
// when this command is installed, user will have to manually install python and rerun the cell
4949
private async installPythonViaKernelPicker(): Promise<void> {
5050
sendTelemetryEvent(Telemetry.PythonNotInstalled, undefined, { action: 'displayed' });
51-
const buttons = this.installedOnceBefore ? [Common.install, Common.reload] : [Common.install];
51+
const buttons = this.installedOnceBefore
52+
? [Common.downloadAndInstall, Common.reload]
53+
: [Common.downloadAndInstall];
5254
const selection = await window.showErrorMessage(DataScience.pythonNotInstalled, { modal: true }, ...buttons);
5355

54-
if (selection === Common.install) {
56+
if (selection === Common.downloadAndInstall) {
5557
this.installedOnceBefore = true;
5658
sendTelemetryEvent(Telemetry.PythonNotInstalled, undefined, { action: 'download' });
5759
// Activate the python extension command to show how to install python

src/platform/common/utils/localize.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ export namespace Common {
1818
export const refresh = l10n.t('Refresh');
1919
export const refreshing = l10n.t('Refreshing...');
2020
export const install = l10n.t('Install');
21+
export const downloadAndInstall = l10n.t('Download and Install');
2122
export const loadingExtension = l10n.t('Jupyter Extension loading...');
2223
export const handleExtensionActivationError = l10n.t(
2324
"Extension activation failed, run the 'Developer: Toggle Developer Tools' command for more information."

0 commit comments

Comments
 (0)