Skip to content

Commit bf5140a

Browse files
authored
Address CG issues (#15807)
1 parent 3fc0b53 commit bf5140a

File tree

5 files changed

+30
-112
lines changed

5 files changed

+30
-112
lines changed

package-lock.json

Lines changed: 23 additions & 108 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2182,7 +2182,7 @@
21822182
"uuid": "^3.3.2",
21832183
"vscode-debugprotocol": "^1.41.0",
21842184
"vscode-languageclient": "8.0.2-next.5",
2185-
"vscode-tas-client": "^0.1.75",
2185+
"vscode-tas-client": "^0.1.84",
21862186
"ws": "^6.2.3",
21872187
"zeromq": "^6.0.0-beta.16",
21882188
"zeromqold": "npm:zeromq@^6.0.0-beta.6"
@@ -2359,6 +2359,9 @@
23592359
"@jupyterlab/coreutils": {
23602360
"url-parse": "$url-parse"
23612361
},
2362+
"@jupyterlab/services": {
2363+
"ws": "7.5.10"
2364+
},
23622365
"d3-color": "3.1.0"
23632366
}
23642367
}

src/kernels/common/kernelSocketWrapper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// Licensed under the MIT License.
33

44
import { EventEmitter } from 'vscode';
5-
import * as WebSocketWS from 'ws';
5+
import type * as WebSocketWS from 'ws';
66
import { ClassType } from '../../platform/ioc/types';
77
import { logger } from '../../platform/logging';
88
import { IKernelSocket } from '../types';

src/kernels/raw/session/rawSocket.node.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import type { KernelMessage } from '@jupyterlab/services';
55
import * as wireProtocol from '@nteract/messaging/lib/wire-protocol';
66
import uuid from 'uuid/v4';
7-
import * as WebSocketWS from 'ws';
7+
import type * as WebSocketWS from 'ws';
88
import type { Dealer, Subscriber } from 'zeromq';
99
import { logger } from '../../../platform/logging';
1010
import { noop } from '../../../platform/common/utils/misc';

src/webviews/webview-side/ipywidgets/kernel/kernel.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { Kernel, KernelMessage, ServerConnection } from '@jupyterlab/services';
66
// eslint-disable-next-line @typescript-eslint/no-restricted-imports
77
import { KernelConnection } from '@jupyterlab/services/lib/kernel/default';
88
import type { ISignal, Signal } from '@lumino/signaling';
9-
import * as WebSocketWS from 'ws';
9+
import type * as WebSocketWS from 'ws';
1010
import { KernelSocketOptions } from '../../../../kernels/types';
1111
import { Deferred, createDeferred } from '../../../../platform/common/utils/async';
1212
import { serializeDataViews, deserializeDataViews } from '../../../../platform/common/utils/serializers';

0 commit comments

Comments
 (0)