Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IPyWidget Rendering to make use of the classes from JupyterLab npm package #14503

Closed
Tracked by #16288
DonJayamanne opened this issue Oct 12, 2023 · 1 comment
Closed
Tracked by #16288
Assignees
Labels
debt Code quality issues ipywidgets Rendering, loading, saving, anything to do with IPyWidgets
Milestone

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Oct 12, 2023

More components/code have been exposed in the JupyterLab npm package making it easier for us to use some of the packages/components.

Look into rendering widgets using WidgetRenderer instead of manually constructing lower level components

  • Create WidgetRenderer
  • Call renderModel to render the widget
  • Then call attach/insert or some similar method on this render object giving it the target element (or a panel that wraps the element)
  • Possibly create another widget new Widget({node: <ele>}) and then attach the output to this new widget

The WidgetRenderer has all of the same code we have in our renderer

@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Oct 12, 2023
@DonJayamanne DonJayamanne self-assigned this Oct 12, 2023
@DonJayamanne DonJayamanne added the ipywidgets Rendering, loading, saving, anything to do with IPyWidgets label Nov 1, 2023
@DonJayamanne DonJayamanne changed the title IPyWidget Rendering Update IPyWidget Rendering to make use of the classes from JupyterLab npm package Nov 1, 2023
@DonJayamanne DonJayamanne added debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug labels Nov 1, 2023
@DonJayamanne DonJayamanne added this to the Backlog milestone Dec 4, 2023
@DonJayamanne
Copy link
Contributor Author

Duplicate of #16288

@DonJayamanne DonJayamanne marked this as a duplicate of #16288 Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues ipywidgets Rendering, loading, saving, anything to do with IPyWidgets
Projects
None yet
Development

No branches or pull requests

1 participant