Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Log Viewer Extension Conflict #1868

Closed
myagizmaktav opened this issue Nov 20, 2022 · 6 comments · Fixed by #1872
Closed

[Bug] Log Viewer Extension Conflict #1868

myagizmaktav opened this issue Nov 20, 2022 · 6 comments · Fixed by #1872
Labels

Comments

@myagizmaktav
Copy link

🐛 What is the bug? How can we reproduce it?

View problem this extension is conflict with
emilast.LogFileHighlighter extension

Please put here any steps, code or any information that can help us
reproduce the error on our side so we can fix it:
Image from Gyazo

Expected behavior

Do not conflict with this extension.

@EzioLi01
Copy link
Collaborator

EzioLi01 commented Nov 21, 2022

Hey @myagizmaktav , thanks for reaching us, you can try on nightly preview version and let me know if you still can see this issue. We have logic to highlight some specific keywords in output log, but have some incompatibility issues to other extensions.
We have disabled some parts of log and plan to refactor them in the future. This changes will work on the next prod release.

@myagizmaktav
Copy link
Author

@EzioLi01 Same problem still continues.

@EzioLi01 EzioLi01 linked a pull request Nov 23, 2022 that will close this issue
@EzioLi01
Copy link
Collaborator

EzioLi01 commented Nov 23, 2022

@myagizmaktav As far as I know, vscode not support config highlight for specific log channel, so it might overwrite or conflict with any 2 colorize extension, I will disable our colorize feature since we need to fix some other issues.
But you maybe face this issue again if you install other colorize extensions. We have created issue in vscode repo to suggest that add specific log channel support, but after discussion it's closed as not plan.
highlight

@myagizmaktav
Copy link
Author

emilast.LogFileHighlighter extension
Image from Gyazo

Then I disabled and open IBM.output-colorizer

Image from Gyazo
still continues.

and I disabled all extensions and try again

Image from Gyazo

@EzioLi01 might be you are not close to this feature I think.

@EzioLi01
Copy link
Collaborator

EzioLi01 commented Nov 23, 2022

Hey @myagizmaktav , this is the latest version for nightly preview.

Now RNT should not have any logic to change output log, it should not overwrite or conflict other extension highlight.

Could you please try this again rather than prod version(maybe you can delete RNT extension folder in .vscode/extension/ folder)? And here is related issue(#1861). We will work on this in the future, any updates I will comment in this issue.

@EzioLi01 EzioLi01 reopened this Nov 23, 2022
@myagizmaktav
Copy link
Author

Fixed @EzioLi01 Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants