Support Node 24: Cannot read properties of undefined (buffer-equal-constant-time) #1139
Description
Hi, first time user here without much experience with JS ecosystem.
I was trying to rebuild an extension from source using vsce, but it failed with an error (see below).
I thought this was due to the extension using some outdated dependencies, but apparently the same error occurs even in a pristine Docker image with just Node 24 installed:
$ docker run --rm -it node:24 npx
--8<--
Entering npm script environment at location:
/
Type 'exit' or ^D when finished
# node --version
v24.0.0
# npm --version
11.3.0
# npx @vscode/vsce --version
Need to install the following packages:
@vscode/[email protected]
Ok to proceed? (y)
/root/.npm/_npx/66fbc91407e86cd3/node_modules/buffer-equal-constant-time/index.js:37
var origSlowBufEqual = SlowBuffer.prototype.equal;
^
TypeError: Cannot read properties of undefined (reading 'prototype')
at Object.<anonymous> (/root/.npm/_npx/66fbc91407e86cd3/node_modules/buffer-equal-constant-time/index.js:37:35)
at Module._compile (node:internal/modules/cjs/loader:1734:14)
at Object..js (node:internal/modules/cjs/loader:1899:10)
at Module.load (node:internal/modules/cjs/loader:1469:32)
at Module._load (node:internal/modules/cjs/loader:1286:12)
at TracingChannel.traceSync (node:diagnostics_channel:322:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
at Module.require (node:internal/modules/cjs/loader:1491:12)
at require (node:internal/modules/helpers:135:16)
at Object.<anonymous> (/root/.npm/_npx/66fbc91407e86cd3/node_modules/jwa/index.js:1:19)
Doing the same thing in the node:23 image works:
$ docker run --rm -it node:23 npx
--8<--
Entering npm script environment at location:
/
Type 'exit' or ^D when finished
# node --version
v23.11.0
# npm --version
10.9.2
# npx @vscode/vsce --version
Need to install the following packages:
@vscode/[email protected]
Ok to proceed? (y)
3.3.2