Skip to content

Commit 1a41ff6

Browse files
authored
🆙 open@^10.1.2 (#250980)
1 parent c5ccd47 commit 1a41ff6

File tree

6 files changed

+110
-31
lines changed

6 files changed

+110
-31
lines changed

package-lock.json

Lines changed: 105 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@
105105
"native-keymap": "^3.3.5",
106106
"native-watchdog": "^1.4.1",
107107
"node-pty": "^1.1.0-beta33",
108-
"open": "^8.4.2",
108+
"open": "^10.1.2",
109109
"tas-client-umd": "0.2.0",
110110
"v8-inspect-profiler": "^0.1.1",
111111
"vscode-oniguruma": "1.7.0",

scripts/code-server.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ async function main() {
3333
const serverArgs = process.argv.slice(2).filter(v => v !== '--launch');
3434
const addr = await startServer(serverArgs);
3535
if (args['launch']) {
36-
open(addr);
36+
open.default(addr);
3737
}
3838
}
3939

scripts/code-web.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ async function main() {
8080

8181
startServer(serverArgs);
8282
if (openSystemBrowser) {
83-
open(`http://${HOST}:${PORT}/`);
83+
open.default(`http://${HOST}:${PORT}/`);
8484
}
8585
}
8686

src/vs/platform/environment/test/node/nativeModules.integrationTest.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,6 @@ flakySuite('Native Modules (all platforms)', () => {
7070
assert.ok(typeof nodePty.spawn === 'function', testErrorMessage('node-pty'));
7171
});
7272

73-
test('open', async () => {
74-
const { default: open } = await import('open');
75-
assert.ok(typeof open === 'function', testErrorMessage('open'));
76-
});
77-
7873
test('@vscode/spdlog', async () => {
7974
const spdlog = await import('@vscode/spdlog');
8075
assert.ok(typeof spdlog.createRotatingLogger === 'function', testErrorMessage('@vscode/spdlog'));

src/vs/platform/native/electron-main/nativeHostMainService.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -584,13 +584,13 @@ export class NativeHostMainService extends Disposable implements INativeHostMain
584584
}
585585

586586
try {
587-
const { default: open } = await import('open');
587+
const { default: open, apps } = await import('open');
588588
const res = await open(url, {
589589
app: {
590590
// Use `open.apps` helper to allow cross-platform browser
591591
// aliases to be looked up properly. Fallback to the
592592
// configured value if not found.
593-
name: Object.hasOwn(open.apps, configuredBrowser) ? open.apps[(configuredBrowser as keyof typeof open['apps'])] : configuredBrowser
593+
name: Object.hasOwn(apps, configuredBrowser) ? apps[(configuredBrowser as keyof typeof apps)] : configuredBrowser
594594
}
595595
});
596596

0 commit comments

Comments
 (0)