add private update dev mode function

microsoft · Aug 15, 2023 · e983119 · e983119
1 parent 39b7db4
commit e983119
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/src/tsconfig.monaco.json b/src/tsconfig.monaco.json
@@ -32,6 +32,7 @@
 		"vs/platform/files/browser/htmlFileSystemProvider.ts",
 		"vs/platform/files/browser/webFileSystemAccess.ts",
 		"vs/platform/telemetry/*",
-		"vs/platform/assignment/*"
+		"vs/platform/assignment/*",
+		"vs/platform/terminal/*"
 	]
 }
diff --git a/...ench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts b/...ench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts
@@ -28,7 +28,6 @@ import type { Terminal } from 'xterm';
 
 class TextAreaSyncContribution extends DisposableStore implements ITerminalContribution {
 	static readonly ID = 'terminal.textAreaSync';
-	private _xterm: IXtermTerminal & { raw: Terminal } | undefined;
 	static get(instance: ITerminalInstance): TextAreaSyncContribution | null {
 		return instance.getContribution<TextAreaSyncContribution>(TextAreaSyncContribution.ID);
 	}

diff --git a/...vs/workbench/contrib/terminalContrib/developer/browser/terminal.developer.contribution.ts b/...vs/workbench/contrib/terminalContrib/developer/browser/terminal.developer.contribution.ts
@@ -110,7 +110,6 @@ registerTerminalAction({
 
 class DevModeContribution extends DisposableStore implements ITerminalContribution {
 	static readonly ID = 'terminal.devMode';
-	devModeClass = 'dev-mode';
 	private _xterm: IXtermTerminal & { raw: Terminal } | undefined;
 	static get(instance: ITerminalInstance): DevModeContribution | null {
 		return instance.getContribution<DevModeContribution>(DevModeContribution.ID);
@@ -123,16 +122,18 @@ class DevModeContribution extends DisposableStore implements ITerminalContributi
 		super();
 		this.add(this._configurationService.onDidChangeConfiguration(e => {
 			if (e.affectsConfiguration(TerminalSettingId.DevMode)) {
-				const devMode: boolean = this._configurationService.getValue(TerminalSettingId.DevMode) || false;
-				this._xterm?.raw.element?.classList.toggle(this.devModeClass, devMode);
+				this._updateDevMode();
 			}
 		}));
 	}
 	xtermReady(xterm: IXtermTerminal & { raw: Terminal }): void {
 		this._xterm = xterm;
-		if (this._configurationService.getValue(TerminalSettingId.DevMode)) {
-			this._xterm.raw.element?.classList.add(this.devModeClass);
-		}
+		this._updateDevMode();
+	}
+
+	private _updateDevMode() {
+		const devMode: boolean = this._configurationService.getValue(TerminalSettingId.DevMode) || false;
+		this._xterm?.raw.element?.classList.toggle('dev-mode', devMode);
 	}
 }
 registerTerminalContribution(DevModeContribution.ID, DevModeContribution);