Skip to content

Commit fca5600

Browse files
committed
Switch to use nodenext module resolution
This better enforces that imports end with a file extension and also use relative paths
1 parent 5e26b3d commit fca5600

File tree

7 files changed

+13
-12
lines changed

7 files changed

+13
-12
lines changed

Diff for: package-lock.json

+5-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@
108108
"v8-inspect-profiler": "^0.1.1",
109109
"vscode-oniguruma": "1.7.0",
110110
"vscode-regexpp": "^3.1.0",
111-
"vscode-textmate": "9.1.0",
111+
"vscode-textmate": "9.2.0",
112112
"yauzl": "^3.0.0",
113113
"yazl": "^2.4.3"
114114
},

Diff for: src/bootstrap-node.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import * as path from 'path';
77
import * as fs from 'fs';
88
import { fileURLToPath } from 'url';
99
import { createRequire } from 'node:module';
10-
import type { IProductConfiguration } from './vs/base/common/product';
10+
import type { IProductConfiguration } from './vs/base/common/product.ts';
1111

1212
const require = createRequire(import.meta.url);
1313
const __dirname = path.dirname(fileURLToPath(import.meta.url));

Diff for: src/tsconfig.base.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"compilerOptions": {
33
"module": "es2022",
4-
"moduleResolution": "node",
4+
"moduleResolution": "nodenext",
55
"experimentalDecorators": true,
66
"noImplicitReturns": true,
77
"noImplicitOverride": true,
@@ -27,4 +27,4 @@
2727
],
2828
"allowSyntheticDefaultImports": true
2929
}
30-
}
30+
}

Diff for: src/vs/platform/telemetry/common/1dsAppender.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ async function getClient(instrumentationKey: string, addInternalFlag?: boolean,
5757

5858
appInsightsCore.initialize(coreConfig, []);
5959

60-
appInsightsCore.addTelemetryInitializer((envelope) => {
60+
appInsightsCore.addTelemetryInitializer((envelope: any) => {
6161
// Opt the user out of 1DS data sharing
6262
envelope['ext'] = envelope['ext'] ?? {};
6363
envelope['ext']['web'] = envelope['ext']['web'] ?? {};

Diff for: src/vs/platform/telemetry/node/1dsAppender.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ export class OneDataSystemAppender extends AbstractOneDataSystemAppender {
105105
) {
106106
// Override the way events get sent since node doesn't have XHTMLRequest
107107
const customHttpXHROverride: IXHROverride = {
108-
sendPOST: (payload: IPayloadData, oncomplete) => {
108+
sendPOST: (payload: IPayloadData, oncomplete: OnCompleteFunc) => {
109109
// Fire off the async request without awaiting it
110110
sendPostAsync(requestService, payload, oncomplete);
111111
}

Diff for: src/vs/workbench/contrib/webview/browser/webviewMessages.d.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
* Licensed under the MIT License. See License.txt in the project root for license information.
44
*--------------------------------------------------------------------------------------------*/
55

6-
import type { IMouseWheelEvent } from 'vs/base/browser/mouseEvent';
7-
import type { WebviewStyles } from 'vs/workbench/contrib/webview/browser/webview';
6+
import type { IMouseWheelEvent } from '../../../../base/browser/mouseEvent.ts';
7+
import type { WebviewStyles } from './webview.ts';
88

99
type KeyEvent = {
1010
key: string;

0 commit comments

Comments
 (0)