Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aux window: allow views and panels #197321

Closed
Evian-Zhang opened this issue Nov 3, 2023 · 13 comments
Closed

Aux window: allow views and panels #197321

Evian-Zhang opened this issue Nov 3, 2023 · 13 comments
Labels
feature-request Request for new features or functionality keep Issues we should not close as out of scope layout General VS Code workbench layout issues workbench-auxwindow Issues related to use of auxiliary ("floating") windows.
Milestone

Comments

@Evian-Zhang
Copy link

Evian-Zhang commented Nov 3, 2023

First of all, thank you for implementing the amazing floating window feature!

Most of the developers use a second monitor with portrait orientation to view and write codes. With a full-screen VSCode, the default side bar at left makes it narrower to write codes, so a general workaround is to move the side bar to the bottom.

However, since we are going to have floating window feature, why not push a step forward: move the side bar into a new window. Then we can move the side bar to another screen, and enjoy a real full-screen code view while we still have the ability to navigate between files in the workspace.

Currently, if we create a floating window from a workspace, then click the files in side bar in the original window will re-focus into the original window, and the new file will be in the original window instead of the floating window. So currently we cannot simulate this feature by writing codes in floating window with original window only having side bar.

There are two approaches to implementing the ability to navigate files in side bar in another window:

  • Move side bar to another window
  • Make side bar at primary window to control all file navigation at all floating windows

I think the first approach is better than the second since the second needs to deal with focus.

@gjsjohnmurray
Copy link
Contributor

a general workaround is to move the activity bar to the bottom.

Please see https://code.visualstudio.com/docs/getstarted/userinterface and confirm whether you are talking about the Activity Bar or the Side Bar.

@Evian-Zhang Evian-Zhang changed the title Aux window: Floating activity bar Aux window: Floating side bar Nov 4, 2023
@Evian-Zhang
Copy link
Author

a general workaround is to move the activity bar to the bottom.

Please see https://code.visualstudio.com/docs/getstarted/userinterface and confirm whether you are talking about the Activity Bar or the Side Bar.

Thank you for pointing out. Fixed it.

@bpasero bpasero added feature-request Request for new features or functionality layout General VS Code workbench layout issues workbench-auxwindow Issues related to use of auxiliary ("floating") windows. and removed triage-needed labels Nov 6, 2023
@bpasero bpasero added this to the Backlog milestone Nov 6, 2023
@bpasero bpasero added the keep Issues we should not close as out of scope label Nov 6, 2023
@bpasero
Copy link
Member

bpasero commented Nov 6, 2023

For clarity: our first version of floating windows will not cover moving non-editors out to separate windows.

@bpasero bpasero changed the title Aux window: Floating side bar Aux window: allow views and panels Nov 6, 2023
@flyingosprey
Copy link

flyingosprey commented Nov 20, 2023

In debug session, please "allow debug panel to be floatable. Etc variables/call statck/watch panels can be floatable.". Variable name could be very long. Once floatable, people can move them to a different monitor to see the full name in a much easy way.

Also, in debug session, please "allow output/debug console panel to be flotable", because people may need run gdb command. The output of the gdb command is genenerally very long too.

Thanks.

@flyingosprey
Copy link

flyingosprey commented Nov 20, 2023

For clarity: our first version of floating windows will not cover moving non-editors out to separate windows.

@bpasero , may I ask a quick Q: now the tab can be detached (etc floatable). When will "re-attach (etc merge them back to the main window after detach) be supported? Is there a ticket for tracking re-attach? (I can file one if none). Thanks

@bpasero
Copy link
Member

bpasero commented Nov 20, 2023

@flyingosprey you can just close the window and all editors will merge back to the active group in the main window.

@flyingosprey
Copy link

@flyingosprey you can just close the window and all editors will merge back to the active group in the main window.

@bpasero , the workaround should work. But it defintiely not convient (you won't feel for helloworld. but you will feel if the folder has tons of file).

Other edtior/IDE who supports "detach" geneerally supports "re-attach". So is it possible to add this support? Thanks

@gjsjohnmurray
Copy link
Contributor

@flyingosprey you can already drag an individual tab off an auxiliary window and drop it back onto the main window.

@flyingosprey
Copy link

@gjsjohnmurray , I am on 1.85.0-insider, which is on Ubuntu 22 LTS with xfce4. I tried "drop it back". No, it does not work. Maybe I am missing sth. Thanks.

@gjsjohnmurray
Copy link
Contributor

@flyingosprey here's what I can do on Windows:

junk

@bpasero
Copy link
Member

bpasero commented Nov 21, 2023

@flyingosprey I think having an extra command makes good sense. While at it, I feel there should be commands for floating windows in general, so for opening floating windows I am adding:

image

And for restoring from a floating window:

image

Happy for feedback on the wording, I quite like the term "detached" over "floating" or "auxiliary".

@gjsjohnmurray
Copy link
Contributor

I also like 'detached'.

Maybe drop 'a' from the first set of new commands?

@bpasero
Copy link
Member

bpasero commented Nov 29, 2023

I only now found #193267 with more upvotes, merging in.

@bpasero bpasero closed this as completed Nov 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality keep Issues we should not close as out of scope layout General VS Code workbench layout issues workbench-auxwindow Issues related to use of auxiliary ("floating") windows.
Projects
None yet
Development

No branches or pull requests

6 participants