Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown preview: Wrong bash syntax highlighting #234911

Closed
max06 opened this issue Nov 29, 2024 · 1 comment
Closed

Markdown preview: Wrong bash syntax highlighting #234911

max06 opened this issue Nov 29, 2024 · 1 comment
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) markdown Markdown support issues

Comments

@max06
Copy link
Contributor

max06 commented Nov 29, 2024

Does this issue occur when all extensions are disabled?: Yes

  • Version: 1.95.2
  • Commit: e865366
  • Date: 2024-11-07T11:07:22.054Z
  • Electron: 32.2.1
  • ElectronBuildId: 10427718
  • Chromium: 128.0.6613.186
  • Node.js: 20.18.0
  • V8: 12.8.374.38-electron.0
  • OS: Linux x64 6.6.62 (NixOS)

Steps to Reproduce:

  1. Create a new markdown file
  2. Paste following content:
# Sample

```sh
nix run github:nix-community/nixos-anywhere -- --flake .#guest-"$TYPE" root@"$TARGET"
` ` ` 

end of sample
  1. Remove spaces from closing code-fences in the sample
  2. Open preview to the side.

Result:
Image

A # only starts a comment in bash when there's a leading space in front of it, or if it's at the beginning of the line.
The code editor highlights it correctly, the preview doesn't. And github is wrong here as well.

@mjbvz
Copy link
Collaborator

mjbvz commented Dec 10, 2024

Would be fixed by #91279

@mjbvz mjbvz closed this as completed Dec 10, 2024
@mjbvz mjbvz added markdown Markdown support issues *duplicate Issue identified as a duplicate of another issue(s) labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*duplicate Issue identified as a duplicate of another issue(s) markdown Markdown support issues
Projects
None yet
Development

No branches or pull requests

2 participants