Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code auto update wrong UI popup and menu entry after update via package manager #30170

Closed
Ragzzy-R opened this issue Jul 6, 2017 · 13 comments
Assignees
Labels
info-needed Issue requires more information from poster install-update VS Code installation and upgrade system issues linux Issues with VS Code on Linux

Comments

@Ragzzy-R
Copy link

Ragzzy-R commented Jul 6, 2017

I'm using Kali Linux and every time When VS Code prompts an update available, It just don't update itself but rather redirects me to the site, makes me download the .deb file and I have to manually install it. This affects the workflow too much. I really love the typescript support that VS Code gives and this issue bothers me a lot. Is there a way/Plugin to do this automatically?

PS: I saw this issue #9539. I can agree that we can't just allow auto update in the background cuz people may rely on one feature which might break on auto-update, but atleast when the user is willing to update(by going to Help->update or clicking update on the notification) there should be automatic background update.

@vscodebot vscodebot bot added the install-update VS Code installation and upgrade system issues label Jul 6, 2017
@joaomoreno
Copy link
Member

https://code.visualstudio.com/docs/setup/linux

Out update story right now on Linux is about Debian and RPM repositories. If you install the deb or rpm, updates come from your system. You should only get the update notification inside Code if you install via the zip archive.

@Ragzzy-R
Copy link
Author

Ragzzy-R commented Jul 6, 2017

@joaomoreno I did install using a .deb package.

From the link you have shared,

Installing the .deb package will automatically install the apt repository and signing key to enable auto-updating using the regular system mechanism

but when I did this

{17-07-06 13:55}kali:~/Vault/projects/whatsup/thumb_access raghuram% sudo apt-get install code
Reading package lists... Done
Building dependency tree       
Reading state information... Done
code is already the newest version (1.13.0-1496940180).
0 upgraded, 0 newly installed, 0 to remove and 66 not upgraded.

so I did this. just in case

{17-07-06 13:55}kali:~/Vault/projects/whatsup/thumb_access raghuram% sudo apt-get --only-upgrade install code      
Reading package lists... Done
Building dependency tree       
Reading state information... Done
code is already the newest version (1.13.0-1496940180).
0 upgraded, 0 newly installed, 0 to remove and 66 not upgraded.

but when Code showed me an update notification and when I clicked it. It took me to the homepage where the current version was 1.13.1. Am I missing something?

@joaomoreno
Copy link
Member

joaomoreno commented Jul 6, 2017

Oh I see, we still show the product popup even when installed from a deb or rpm. Is that right, @Tyriar ?

@joaomoreno joaomoreno reopened this Jul 6, 2017
@joaomoreno joaomoreno added the info-needed Issue requires more information from poster label Jul 6, 2017
@Ragzzy-R
Copy link
Author

Ragzzy-R commented Jul 6, 2017

@joaomoreno I was wondering why apt-get couldn't see the update. any ideas? or is it 1.13.1 is not updated in the package repos yet?

Also I was wondering if something like "one click(in the notification popup)->install in background and then restart Code" kinda thing could be made? is it already in the bucketlist? or shall I raise a feature request? 😄 It would be real helpful. I know you guys have lot in your plate. but just curious

@joaomoreno
Copy link
Member

#10857 would definitely enable us to provide a one click update. 👍

@Tyriar Tyriar changed the title VS Code - Auto update. VS Code auto update giving notification when there is no update on Linux Jul 6, 2017
@Tyriar Tyriar added debt Code quality issues linux Issues with VS Code on Linux and removed info-needed Issue requires more information from poster labels Jul 6, 2017
@Tyriar
Copy link
Member

Tyriar commented Jul 6, 2017

@Ragzzy-R you're on 1.13.0 which shouldn't be happening. The repo is here and it shows 1.13.1 for me https://packages.microsoft.com/repos/vscode/pool/main/c/code/

image

Are you sure you're updating your apt cache? apt update

@Tyriar Tyriar added info-needed Issue requires more information from poster and removed debt Code quality issues labels Jul 6, 2017
@Ragzzy-R
Copy link
Author

Ragzzy-R commented Jul 6, 2017

Well I'm not sure if I apt-updated before doing it . Maybe that's a reason. Sorry couldn't test it as I have already manually updated to 1.13.1.

@Tyriar
Copy link
Member

Tyriar commented Jul 6, 2017

Definitely works for me, you could also verify that the sync happens correctly in the apt update output. I'll close this off for now, please let us know if you run into the issue again.

@Tyriar Tyriar closed this as completed Jul 6, 2017
@colmartofus
Copy link

I have the same bug. I installed with deb and upgraded via apt. My "bout" says I'm running 1.14.0. The pop up brings me to a page for 1.14. apt update/upgrade says I have the newest version.

@Ragzzy-R
Copy link
Author

Hello,
I think I stated the issue incorrectly. What exactly happens is. When installing the deb file using dpkg, the key gets added to the package manager and we could update via normal package manager upgrades.

On the other hand, we still get popups on VS Code inside the editor about an update(whenever available and not after update via package manager). When you click on it, it takes you to the download page.

Also even after I update via my package manager, whenever i launch my VS Code, and go to help->check for updates, nothing pops up(thats fine) but when I again click "help" I could see "download available update" which redirect to download page in browser.

The actual mechanism should be when we click on it, it should initiate a update with the package manager or at least no popup should be shown so that the user will eventually update when he does a system update.

@Ragzzy-R Ragzzy-R changed the title VS Code auto update giving notification when there is no update on Linux VS Code auto update wrong UI popup and menu entry after update via package manager Sep 27, 2017
@Tyriar
Copy link
Member

Tyriar commented Sep 27, 2017

@Ragzzy-R the popup doesn't actually check the repo, but our update server, and they can occasionally get out of sync. The item tracking this is #21651

@Ragzzy-R
Copy link
Author

ohh thanks! and what about the menu issue stated above?

@Tyriar
Copy link
Member

Tyriar commented Sep 28, 2017

It's the same issue, the menu says Download available update because it thinks there is an update. No plans to try open the package manager because we cannot be sure that the repo and key is installed and also it would be difficult to get working across distros.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster install-update VS Code installation and upgrade system issues linux Issues with VS Code on Linux
Projects
None yet
Development

No branches or pull requests

4 participants