Folder decorations don't go away when file with problems is deleted

[roblourens]

• Create empty folder
• git init (This only reproes when a git repo is present)
• Add a folder foo/
• Add a file inside that folder test.ts
• Type something like invalid syntax in test.ts so that it has TS errors
• See that folder foo is highlighted red in the explorer
• In the file explorer, delete foo test.ts
• foo is still red!

Doesn't repro in 1.28

[jrieken]

I am actually not able to reproduce... When deleting the file it takes a short while (1-2 sec) the folder decoration disappears...

[roblourens]

I can still repro, but not every time. Can you give me some pointers on where to set breakpoints?

[jrieken]

try this for a start: https://github.com/Microsoft/vscode/blob/17c90f611441274b3e55cec764cefc737770373e/src/vs/workbench/services/decorations/browser/decorationsService.ts#L400. It should be called from the label itself

[roblourens]

When it reproes, I see it call that only once after I delete test.ts. It's called as a result of the treeview refreshing. It seems to find out about the error decoration from the child.

When it doesn't repro, then I also see it called a few more times with this stack

FileDecorationsService.getDecoration (/Users/roblou/code/vscode/src/vs/workbench/services/decorations/browser/decorationsService.ts:401)
ResourceLabel.render (/Users/roblou/code/vscode/src/vs/workbench/browser/labels.ts:213)
ResourceLabel.onFileDecorationsChanges (/Users/roblou/code/vscode/src/vs/workbench/browser/labels.ts:112)
(anonymous function) (/Users/roblou/code/vscode/src/vs/base/common/event.ts:328)
Emitter.fire (/Users/roblou/code/vscode/src/vs/base/common/event.ts:145)
(anonymous function) (/Users/roblou/code/vscode/src/vs/base/common/event.ts:356)

[vscodebot]

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

[jrieken]

This is still a mystery. I have pushed a test that we emit an event for the parent folder when the decoration change for the child folder. Tho, it might be that the marker isn't actually removed. @roblourens when you see this, is the problems view empty or does it still show the error?

[roblourens]

It's still in the problems view too.

[jrieken]

Ok, that makes it a TypeScript issue... Since the marker is still there (and bubbles) it will be shown on any parent folder. It must be removed from the marker service to be cleaned up in the UI

[mjbvz]

Duplicate of #61919

[roblourens]

That's this issue 🤦‍♂️

[mjbvz]

Sorry, should be #61773

@roblourens Is there a (deleted from disk) file still open in your editor like in #58088?

[roblourens]

No