Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test support to optionally test using a signed service library #57

Open
MIchaelMainer opened this issue Oct 28, 2019 · 2 comments
Open
Assignees
Milestone

Comments

@MIchaelMainer
Copy link
Contributor

MIchaelMainer commented Oct 28, 2019

Some M.G.D.C.Test tests take a dependency on models in M.G service library. This is fine as long as we only need to use the non-collection models like User. Otherwise, all of the collection models and request builders take a dependency on the M.G.C which is signed.

So, we need to support tests that target M.G.C in the project, and the signed+published service library and its dependency on the signed+published M.G.C.

I think we can achieve this by adding an alias to the test reference in M.G.D.C.Test project to the M.G.C project and updating the tests to use that, and then we can add a reference to the signed+published M.G.C NuGet so we can test using the service library when it requires a reference to objects defined in M.G.C.

Another option would be to bring in the service library as a submodule, and reference it via a project via an alias.

This enables:

var deltaResponse = await deltaResponseHandler.HandleResponse<EventDeltaCollectionResponse>(hrm);
EventDeltaCollectionPage deltaResponsePage = deltaResponse.Value; 
// deltaResponse.Value[0] is a property on ICollectionPage which is in the signed M.G.C 
var body = deltaResponsePage.Value[0].Body; // Can't do this now

AB#7201

@ghost ghost added the Needs: Triage label Oct 28, 2019
@MIchaelMainer
Copy link
Contributor Author

One solution to consider for test purposes: let's start copying-paste code as needed from service library.

@ddyett
Copy link
Contributor

ddyett commented Jun 29, 2023

@MIchaelMainer @andrueastman something we still need?

@ddyett ddyett assigned andrueastman and unassigned MIchaelMainer Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants