Code cleanup and fixing translations.

Author: renemadsen

eFormAPI/Plugins/TimePlanning.Pn/TimePlanning.Pn/Infrastructure/Models/Planning/PlanRegistrationVersionModel.cs

@@ -32,6 +32,7 @@ public class PlanRegistrationVersionModel
     public int Version { get; set; }
     public DateTime UpdatedAt { get; set; }
     public int? UpdatedByUserId { get; set; }
+    public string UpdatedByUserName { get; set; }
     public List<FieldChange> Changes { get; set; } = [];
 }
 

eFormAPI/Plugins/TimePlanning.Pn/TimePlanning.Pn/Services/TimePlanningPlanningService/TimePlanningPlanningService.cs

@@ -520,6 +520,7 @@ public async Task<OperationResult> Update(int id, TimePlanningPlanningPrDayModel
     {
         try
         {
+            var currentUserAsync = await userService.GetCurrentUserAsync();
             var planning = dbContext.PlanRegistrations
                 .Where(x => x.WorkflowState != Constants.WorkflowStates.Removed)
                 .FirstOrDefault(x => x.Id == id);
@@ -965,6 +966,7 @@ await dbContext.PlanRegistrations.AsNoTracking()
 
             // Compute time tracking fields (seconds-based calculation)
             PlanRegistrationHelper.ComputeTimeTrackingFields(planning);
+            planning.UpdatedByUserId = currentUserAsync.Id;
 
             await planning.Update(dbContext).ConfigureAwait(false);
             var todayDateMidnight = new DateTime(DateTime.Now.Year, DateTime.Now.Month, DateTime.Now.Day, 0, 0, 0);
@@ -1483,6 +1485,7 @@ await dbContext.PlanRegistrations.AsNoTracking()
 
             // Compute time tracking fields (seconds-based calculation)
             PlanRegistrationHelper.ComputeTimeTrackingFields(planning);
+            planning.UpdatedByUserId = currentUser.Id;
 
             await planning.Update(dbContext).ConfigureAwait(false);
             var todayDateMidnight = new DateTime(DateTime.Now.Year, DateTime.Now.Month, DateTime.Now.Day, 0, 0, 0);
@@ -1783,6 +1786,8 @@ public async Task<OperationDataResult<PlanRegistrationVersionHistoryModel>> GetV
                         Version = currentVersion.Version,
                         UpdatedAt = currentVersion.UpdatedAt ?? DateTime.UtcNow,
                         UpdatedByUserId = currentVersion.UpdatedByUserId,
+                        UpdatedByUserName = currentVersion.UpdatedByUserId == 1 ? "System"
+                            : await userService.GetFullNameUserByUserIdAsync(currentVersion.UpdatedByUserId).ConfigureAwait(false),
                         Changes = changes
                     });
                 }

eform-client/src/app/plugins/modules/time-planning-pn/components/plannings/time-planning-actions/assigned-site/assigned-site-dialog.component.html

@@ -175,15 +175,15 @@
                       [name]="'isManager'"
                       formControlName="isManager">
           <div>
-            <div>{{ 'Is Manager' | translate }}</div>
+            <div>{{ 'Is manager' | translate }}</div>
             <small class="checkbox-description">{{ 'Set this user as a manager' | translate }}</small>
           </div>
         </mat-checkbox>
       </div>
-      
+
       <div class="d-flex flex-row" *ngIf="!data.resigned && data.isManager && selectCurrentUserIsAdmin$ | async">
         <mat-form-field class="p-1 w-100">
-          <mat-label>{{ 'Managing Tags' | translate }}</mat-label>
+          <mat-label>{{ 'Managing tags' | translate }}</mat-label>
           <mtx-select
             [items]="availableTags"
             bindLabel="name"

eform-client/src/app/plugins/modules/time-planning-pn/components/plannings/time-planning-actions/version-history-modal/version-history-modal.component.html

@@ -10,8 +10,8 @@ <h4 class="modal-title">Version History</h4>
     <div class="versions-panel" [class.with-side-panel]="selectedGpsCoordinate || selectedSnapshot">
       <div *ngFor="let version of versionHistory.versions" class="version-section">
         <h5>
-          {{ formatDateTime(version.updatedAt) }} Values changed
-          <span *ngIf="version.updatedByUserId">by User ID: {{ version.updatedByUserId }} ({{version.version}})</span>
+          {{ formatDateTime(version.updatedAt) }} {{ 'Values changed' | translate }}
+          <span *ngIf="version.updatedByUserId">{{ 'by user' | translate }}: {{ version.updatedByUserName }} ({{version.version}})</span>
         </h5>
 
         <mtx-grid
@@ -28,7 +28,7 @@ <h5>
       </div>
 
       <div *ngIf="versionHistory.versions.length === 0" class="no-versions">
-        <p>No version history available.</p>
+        <p>{{ 'No version history available.' | translate}}</p>
       </div>
     </div>
 
@@ -63,12 +63,12 @@ <h5>
 <ng-template #toValueTemplate let-row>
   <ng-container *ngIf="row.fieldType === 'gps'">
     <a href="javascript:void(0)" (click)="onGpsClick(row)">
-      View on Maps ({{ row.latitude }}, {{ row.longitude }})
+      {{ 'View on Maps' | translate }} ({{ row.latitude }}, {{ row.longitude }})
     </a>
   </ng-container>
   <ng-container *ngIf="row.fieldType === 'snapshot'">
     <a href="javascript:void(0)" (click)="onSnapshotClick(row)">
-      View Snapshot
+      {{ 'View Snapshot' | translate }}
     </a>
   </ng-container>
   <ng-container *ngIf="row.fieldType === 'standard'">
@@ -79,7 +79,7 @@ <h5>
 <div class="modal-body" *ngIf="loading">
   <div class="text-center">
     <div class="spinner-border" role="status">
-      <span class="sr-only">Loading...</span>
+      <span class="sr-only">{{ 'Loading...' | translate}}</span>
     </div>
   </div>
 </div>

eform-client/src/app/plugins/modules/time-planning-pn/i18n/bgBG.ts

@@ -144,4 +144,47 @@ export const bgBG = {
   Maternity: 'Отпуск по майчинство',
   VacationDayOff: 'Почивен ден',
   Holiday: 'Празник',
+  'Absence Requests': 'Заявки за отсъствия',
+  Inbox: 'Входяща поща',
+  'My Requests': 'Моите заявки',
+  'Absence Request': 'Заявка за отсъствие',
+  'Approve Absence Request': 'Одобряване на заявка за отсъствие',
+  'Reject Absence Request': 'Отхвърляне на заявка за отсъствие',
+  'Request ID': 'Идентификационен номер на заявката',
+  'Requested By': 'Заявено от',
+  'Date From': 'Дата от',
+  'Date To': 'Дата до',
+  Status: 'Статус',
+  'Requested At': 'Заявено в',
+  'Request Comment': 'Заявка за коментар',
+  'Decision Comment (Optional)': 'Коментар към решението (по избор)',
+  'Rejection Comment (Optional)': 'Коментар за отхвърляне (по избор)',
+  Approve: 'Одобряване',
+  Reject: 'Отхвърляне',
+  Pending: 'В очакване',
+  Approved: 'Одобрено',
+  Rejected: 'Отхвърлено',
+  'No absence requests found': 'Няма намерени заявки за отсъствие',
+  'Error loading absence requests': 'Грешка при зареждане на заявките за отсъствие',
+  'Absence request approved successfully': 'Заявката за отсъствие е одобрена успешно',
+  'Error approving absence request': 'Грешка при одобряване на заявката за отсъствие',
+  'Absence request rejected successfully': 'Заявката за отсъствие е успешно отхвърлена',
+  'Error rejecting absence request': 'Грешка при отхвърляне на заявката за отсъствие',
+  'User not authenticated': 'Потребителят не е удостоверен',
+  'Values changed': 'Променени стойности',
+  'by user': 'от потребител',
+  'No version history available.': 'Няма налична история на версиите.',
+  'View on Maps': 'Преглед в Карти',
+  'View Snapshot': 'Преглед на моментна снимка',
+  'Loading...': 'Зареждане...',
+  Variable: 'Променлива',
+  'From value': 'От стойност',
+  'To value': 'Да се оцени',
+  'Is manager': 'Е мениджър',
+  'Set this user as a manager': 'Задаване на този потребител като мениджър',
+  'Managing tags': 'Управление на етикети',
+  'Select tags that this manager is responsible for': 'Изберете етикети, за които този мениджър е отговорен',
+  'Select tags': 'Изберете етикети',
+  'Reconciled in accounting': 'Съгласувано в счетоводството',
+  'Transferred to payroll': 'Прехвърлено към заплатата',
 };

eform-client/src/app/plugins/modules/time-planning-pn/i18n/csCZ.ts

@@ -144,4 +144,47 @@ export const csCZ = {
   Maternity: 'Mateřská dovolená',
   VacationDayOff: 'Volný den',
   Holiday: 'Dovolená',
+  'Absence Requests': 'Žádosti o nepřítomnost',
+  Inbox: 'Doručená pošta',
+  'My Requests': 'Moje požadavky',
+  'Absence Request': 'Žádost o nepřítomnost',
+  'Approve Absence Request': 'Schválit žádost o nepřítomnost',
+  'Reject Absence Request': 'Zamítnout žádost o nepřítomnost',
+  'Request ID': 'ID požadavku',
+  'Requested By': 'Požadováno uživatelem',
+  'Date From': 'Datum od',
+  'Date To': 'Datum do',
+  Status: 'Postavení',
+  'Requested At': 'Požadováno v',
+  'Request Comment': 'Žádost o komentář',
+  'Decision Comment (Optional)': 'Komentář k rozhodnutí (volitelné)',
+  'Rejection Comment (Optional)': 'Komentář k odmítnutí (volitelné)',
+  Approve: 'Schvalovat',
+  Reject: 'Odmítnout',
+  Pending: 'Čeká na vyřízení',
+  Approved: 'Schválený',
+  Rejected: 'Odmítnuto',
+  'No absence requests found': 'Nenalezeny žádné žádosti o absenci',
+  'Error loading absence requests': 'Chyba při načítání žádostí o absenci',
+  'Absence request approved successfully': 'Žádost o absenci byla úspěšně schválena',
+  'Error approving absence request': 'Chyba při schvalování žádosti o absenci',
+  'Absence request rejected successfully': 'Žádost o absenci byla úspěšně zamítnuta',
+  'Error rejecting absence request': 'Chyba při zamítnutí žádosti o absenci',
+  'User not authenticated': 'Uživatel nebyl ověřen',
+  'Values changed': 'Hodnoty změněny',
+  'by user': 'uživatelem',
+  'No version history available.': 'Historie verzí není k dispozici.',
+  'View on Maps': 'Zobrazit na Mapách',
+  'View Snapshot': 'Zobrazit snímek',
+  'Loading...': 'Načítání...',
+  Variable: 'Proměnná',
+  'From value': 'Z hodnoty',
+  'To value': 'Hodnotit',
+  'Is manager': 'Je manažer',
+  'Set this user as a manager': 'Nastavit tohoto uživatele jako správce',
+  'Managing tags': 'Správa štítků',
+  'Select tags that this manager is responsible for': 'Vyberte štítky, za které je tento správce zodpovědný',
+  'Select tags': 'Vyberte štítky',
+  'Reconciled in accounting': 'Odsouhlaseno v účetnictví',
+  'Transferred to payroll': 'Převedeno na mzdu',
 };

eform-client/src/app/plugins/modules/time-planning-pn/i18n/da.ts

@@ -143,7 +143,7 @@ export const da = {
   VacationDayOff: 'Afspadsering',
   Holiday: 'Helligdag',
   'Absence Requests': 'Fraværsanmodninger',
-  'Inbox': 'Indbakke',
+  Inbox: 'Indbakke',
   'My Requests': 'Mine anmodninger',
   'Absence Request': 'Fraværsanmodning',
   'Approve Absence Request': 'Godkend fraværsanmodning',
@@ -152,21 +152,37 @@ export const da = {
   'Requested By': 'Anmodet af',
   'Date From': 'Fra dato',
   'Date To': 'Til dato',
-  'Status': 'Status',
+  Status: 'Status',
   'Requested At': 'Anmodet den',
   'Request Comment': 'Anmodningskommentar',
   'Decision Comment (Optional)': 'Beslutningskommentar (valgfrit)',
   'Rejection Comment (Optional)': 'Afvisningskommentar (valgfrit)',
-  'Approve': 'Godkend',
-  'Reject': 'Afvis',
-  'Pending': 'Afventer',
-  'Approved': 'Godkendt',
-  'Rejected': 'Afvist',
+  Approve: 'Godkend',
+  Reject: 'Afvis',
+  Pending: 'Afventer',
+  Approved: 'Godkendt',
+  Rejected: 'Afvist',
   'No absence requests found': 'Ingen fraværsanmodninger fundet',
   'Error loading absence requests': 'Fejl ved indlæsning af fraværsanmodninger',
   'Absence request approved successfully': 'Fraværsanmodning godkendt',
   'Error approving absence request': 'Fejl ved godkendelse af fraværsanmodning',
   'Absence request rejected successfully': 'Fraværsanmodning afvist',
   'Error rejecting absence request': 'Fejl ved afvisning af fraværsanmodning',
   'User not authenticated': 'Bruger ikke godkendt',
+  'Values changed': 'Værdier ændret',
+  'by user': 'af bruger',
+  'No version history available.': 'Ingen versionshistorik tilgængelig.',
+  'View on Maps': 'Vis på kort',
+  'View Snapshot': 'Se øjebliksbillede',
+  'Loading...': 'Indlæser...',
+  Variable: 'Variabel',
+  'From value': 'Fra værdi',
+  'To value': 'At værdsætte',
+  'Is manager': 'Er leder',
+  'Set this user as a manager': 'Angiv denne bruger som administrator',
+  'Managing tags': 'Administration af tags',
+  'Select tags that this manager is responsible for': 'Vælg tags, som denne administrator er ansvarlig for',
+  'Select tags': 'Vælg tags',
+  'Reconciled in accounting': 'Afstemt i regnskabet',
+  'Transferred to payroll': 'Overført til lønudbetaling',
 };

eform-client/src/app/plugins/modules/time-planning-pn/i18n/deDE.ts

@@ -144,4 +144,47 @@ export const deDE = {
   Maternity: 'Mutterschaftsurlaub',
   VacationDayOff: 'Urlaubstag frei',
   Holiday: 'Urlaub',
+  'Absence Requests': 'Abwesenheitsanträge',
+  Inbox: 'Posteingang',
+  'My Requests': 'Meine Anfragen',
+  'Absence Request': 'Abwesenheitsantrag',
+  'Approve Absence Request': 'Abwesenheitsantrag genehmigen',
+  'Reject Absence Request': 'Abwesenheitsantrag ablehnen',
+  'Request ID': 'Anforderungs-ID',
+  'Requested By': 'Angefordert von',
+  'Date From': 'Stammen aus',
+  'Date To': 'Datum bis',
+  Status: 'Status',
+  'Requested At': 'Angefordert bei',
+  'Request Comment': 'Kommentar anfordern',
+  'Decision Comment (Optional)': 'Kommentar zur Entscheidung (optional)',
+  'Rejection Comment (Optional)': 'Ablehnungskommentar (optional)',
+  Approve: 'Genehmigen',
+  Reject: 'Ablehnen',
+  Pending: 'Ausstehend',
+  Approved: 'Genehmigt',
+  Rejected: 'Abgelehnt',
+  'No absence requests found': 'Keine Abwesenheitsanträge gefunden',
+  'Error loading absence requests': 'Fehler beim Laden von Abwesenheitsanfragen',
+  'Absence request approved successfully': 'Abwesenheitsantrag erfolgreich genehmigt',
+  'Error approving absence request': 'Fehler bei der Genehmigung des Abwesenheitsantrags',
+  'Absence request rejected successfully': 'Abwesenheitsantrag erfolgreich abgelehnt',
+  'Error rejecting absence request': 'Fehler beim Abwesenheitsantrag',
+  'User not authenticated': 'Benutzer nicht authentifiziert',
+  'Values changed': 'Werte geändert',
+  'by user': 'vom Benutzer',
+  'No version history available.': 'Es ist kein Versionsverlauf verfügbar.',
+  'View on Maps': 'Auf Karten anzeigen',
+  'View Snapshot': 'Momentaufnahme anzeigen',
+  'Loading...': 'Laden...',
+  Variable: 'Variable',
+  'From value': 'Aus Wert',
+  'To value': 'Wert',
+  'Is manager': 'Ist der Manager',
+  'Set this user as a manager': 'Diesen Benutzer als Manager festlegen',
+  'Managing tags': 'Tags verwalten',
+  'Select tags that this manager is responsible for': 'Wählen Sie die Schlagwörter aus, für die dieser Manager zuständig ist.',
+  'Select tags': 'Schlagwörter auswählen',
+  'Reconciled in accounting': 'In der Buchhaltung abgeglichen.',
+  'Transferred to payroll': 'An die Gehaltsabrechnung übertragen.',
 };

eform-client/src/app/plugins/modules/time-planning-pn/i18n/elGR.ts

@@ -144,4 +144,47 @@ export const elGR = {
   Maternity: 'Άδεια μητρότητας',
   VacationDayOff: 'Ημέρα διακοπών',
   Holiday: 'Αργία',
+  'Absence Requests': 'Αιτήματα Απουσίας',
+  Inbox: 'Εισερχόμενα',
+  'My Requests': 'Τα αιτήματά μου',
+  'Absence Request': 'Αίτηση Απουσίας',
+  'Approve Absence Request': 'Έγκριση αιτήματος απουσίας',
+  'Reject Absence Request': 'Απόρριψη αιτήματος απουσίας',
+  'Request ID': 'Αίτημα Αναγνωριστικού',
+  'Requested By': 'Αίτημα από',
+  'Date From': 'Ημερομηνία από',
+  'Date To': 'Ημερομηνία έως',
+  Status: 'Κατάσταση',
+  'Requested At': 'Ζητήθηκε στις',
+  'Request Comment': 'Αίτημα σχολίου',
+  'Decision Comment (Optional)': 'Σχόλιο Απόφασης (Προαιρετικό)',
+  'Rejection Comment (Optional)': 'Σχόλιο απόρριψης (Προαιρετικό)',
+  Approve: 'Εγκρίνω',
+  Reject: 'Απορρίπτω',
+  Pending: 'Εκκρεμής',
+  Approved: 'Εγκρίθηκε',
+  Rejected: 'Απορρίφθηκε',
+  'No absence requests found': 'Δεν βρέθηκαν αιτήματα απουσίας',
+  'Error loading absence requests': 'Σφάλμα κατά τη φόρτωση αιτημάτων απουσίας κατά τη φόρτωση',
+  'Absence request approved successfully': 'Το αίτημα απουσίας εγκρίθηκε με επιτυχία',
+  'Error approving absence request': 'Σφάλμα κατά την έγκριση αιτήματος απουσίας κατά την έγκριση του αιτήματος απουσίας.',
+  'Absence request rejected successfully': 'Το αίτημα απουσίας απορρίφθηκε με επιτυχία',
+  'Error rejecting absence request': 'Σφάλμα απόρριψης αιτήματος απουσίας κατά την απόρριψη αιτήματος απουσίας',
+  'User not authenticated': 'Ο χρήστης δεν έχει πιστοποιηθεί',
+  'Values changed': 'Αλλαγή τιμών',
+  'by user': 'από τον χρήστη',
+  'No version history available.': 'Δεν υπάρχει διαθέσιμο ιστορικό εκδόσεων.',
+  'View on Maps': 'Προβολή στους Χάρτες',
+  'View Snapshot': 'Προβολή στιγμιότυπου',
+  'Loading...': 'Φόρτωση...',
+  Variable: 'Μεταβλητός',
+  'From value': 'Από την τιμή',
+  'To value': 'Να εκτιμήσω',
+  'Is manager': 'Είναι διευθυντής',
+  'Set this user as a manager': 'Ορισμός αυτού του χρήστη ως διαχειριστή',
+  'Managing tags': 'Διαχείριση ετικετών',
+  'Select tags that this manager is responsible for': 'Επιλέξτε ετικέτες για τις οποίες είναι υπεύθυνος αυτός ο διαχειριστής',
+  'Select tags': 'Επιλογή ετικετών',
+  'Reconciled in accounting': 'Συμφωνημένο στη λογιστική',
+  'Transferred to payroll': 'Μεταφέρθηκε στη μισθοδοσία',
 };

eform-client/src/app/plugins/modules/time-planning-pn/i18n/enUS.ts

@@ -169,4 +169,20 @@ export const enUS = {
   'Absence request rejected successfully': 'Absence request rejected successfully',
   'Error rejecting absence request': 'Error rejecting absence request',
   'User not authenticated': 'User not authenticated',
+  'Values changed': 'Values changed',
+  'by user': 'by user',
+  'No version history available.': 'No version history available.',
+  'View on Maps': 'View on Maps',
+  'View Snapshot': 'View Snapshot',
+  'Loading...': 'Loading...',
+  'Variable': 'Variable',
+  'From value': 'From value',
+  'To value': 'To value',
+  'Is manager': 'Is manager',
+  'Set this user as a manager': 'Set this user as a manager',
+  'Managing tags': 'Managing tags',
+  'Select tags that this manager is responsible for': 'Select tags that this manager is responsible for',
+  'Select tags': 'Select tags',
+  'Reconciled in accounting': 'Reconciled in accounting',
+  'Transferred to payroll': 'Transferred to payroll',
 };