Is there a way to change the cwd in nvim when yazi exits? #95

bertradio · 2024-05-22T08:18:09Z

bertradio
May 22, 2024

I would like to be able to use yazi to change directories in nvim... similar to yy in bashrc. In other words, if in yazi I change the directory to /bin, when I exit yazi the cwd in nvim would change to /bin.

mikavilpas · 2024-05-22T10:34:37Z

mikavilpas
May 22, 2024
Maintainer

That's a great idea. I think it could be done if I add a way to know what the last directory was when yazi was quit, and if you then add a custom hook.

It sounds good. I actually started adding this feature (last yazi directory) yesterday because I had an idea for another feature.

My idea was to add an optional keybinding for closing yazi and grepping the selected directory using telescope or whatever the user wants to do.

Let's keep this open.

0 replies

mikavilpas · 2024-05-22T10:35:56Z

mikavilpas
May 22, 2024
Maintainer

By the way, when you change the cwd in nvim, does it cause issues for your other tools such as LSPs or linters, etc? I typically don't change the cwd in my workflow right now, so I don't know.

0 replies

bertradio · 2024-05-22T12:17:39Z

bertradio
May 22, 2024
Author

I do move around a lot in nvim and it's often convenient to change the cwd. The yazi site has this code to create a function in .bashrc to do exactly that: function yy() { local tmp tmp="$(mktemp -t "yazi-cwd.XXXXXX")" yazi "$@" --cwd-file="$tmp" if cwd="$(cat -- "$tmp")" && [ -n "$cwd" ] && [ "$cwd" != "$PWD" ]; then cd -- "$cwd" || exit fi rm -f -- "$tmp" }

…

On Wed, May 22, 2024, at 12:34, Mika Vilpas wrote: That's a great idea. I think it could be done if I add a way to know what the last directory was when yazi was quit, and if you then add a custom hook. It sounds good. I actually started adding this feature (last yazi directory) yesterday because I had an idea for another feature. My idea was to add an optional keybinding for closing yazi and grepping the selected directory using telescope or whatever the user wants to do. Let's keep this open. — Reply to this email directly, view it on GitHub <#83 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLYYRL5TIPBZACMY2YMOVTZDRYFFAVCNFSM6AAAAABIDDQX36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRUGQ3DKMJWGY>. You are receiving this because you authored the thread.Message ID: ***@***.***>

0 replies

mikavilpas · 2024-05-22T12:43:16Z

mikavilpas
May 22, 2024
Maintainer

I use the same thing in my shell, actually. It's really useful.

How have you found LSP and other tools to work if you change your cwd in neovim?

0 replies

bertradio · 2024-05-22T12:53:29Z

bertradio
May 22, 2024
Author

I've had no problems at all. i'm not a programmer, but I use nvim for all my text editing, especially markdown. Accessing yazi from within nvim has been a big help to me.

…

On Wed, May 22, 2024, at 14:43, Mika Vilpas wrote: I use the same thing in my shell, actually. It's really useful. How have you found LSP and other tools to work if you change your cwd in neovim? — Reply to this email directly, view it on GitHub <#83 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLYYRNJMK2KJJMIT4KH4JDZDSHHRAVCNFSM6AAAAABIDDQX36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRUGY4TSNJXGQ>. You are receiving this because you authored the thread.Message ID: ***@***.***>

0 replies

mikavilpas · 2024-05-22T18:24:37Z

mikavilpas
May 22, 2024
Maintainer

Ok, I have something that might work for you in the PR autolinked above.

Here's how I set it up in my config:

{
    -- "mikavilpas/yazi.nvim",
    dir = "~/git/yazi.nvim/",
    dependencies = {
      "nvim-lua/plenary.nvim",
    },
    event = "VeryLazy",
    keys = {
      {
        "<up>",
        function()
          require("yazi").yazi()
        end,
        desc = "Open the file manager",
      },
      {
        "<s-up>",
        function()
          require("yazi").yazi(nil, vim.fn.getcwd())
        end,
        desc = "Open the file manager in the cwd",
      },
    },
    ---@type YaziConfig
    opts = {
      open_for_directories = true,
      enable_mouse_support = true,
      -- log_level = vim.log.levels.DEBUG,
      ---@diagnostic disable-next-line: missing-fields
      hooks = {
        yazi_closed_successfully = function(chosen_file, config, state)
          vim.notify(vim.inspect({ chosen_file, state.last_directory.filename }))
        end,
      },
    },
  }

Basically, you can use the yazi_closed_successfully hook. I added a new parameter for information that is known when yazi has closed.

Do you know how to try that out? You can add branch = "cd-events" to your lazy.nvim spec if you're using that.

0 replies

bertradio · 2024-05-22T19:59:57Z

bertradio
May 22, 2024
Author

Attached is my yazi config. When I enter yazi and change directory then exit it does not change the cwd. Instead I get this notification. .{ [2] = "/home/bert/.config/nvim" }

…

On Wed, May 22, 2024, at 20:24, Mika Vilpas wrote: Ok, I have something that might work for you in the PR autolinked above. Here's how I set it up in my config: { -- "mikavilpas/yazi.nvim", dir = "~/git/yazi.nvim/", dependencies = { "nvim-lua/plenary.nvim", }, event = "VeryLazy", keys = { { "<up>", function() require("yazi").yazi() end, desc = "Open the file manager", }, { "<s-up>", function() require("yazi").yazi(nil, vim.fn.getcwd()) end, desc = "Open the file manager in the cwd", }, }, ***@***.*** YaziConfig opts = { open_for_directories = true, enable_mouse_support = true, -- log_level = vim.log.levels.DEBUG, ***@***.*** disable-next-line: missing-fields hooks = { yazi_closed_successfully = function(chosen_file, config, state) vim.notify(vim.inspect({ chosen_file, state.last_directory.filename })) end, }, }, } Basically, you can use the `yazi_closed_successfully` hook. I added a new parameter for information that is known when yazi has closed. Do you know how to try that out? You can add Cto your lazy.nvim spec if you're using that. —m Reply to this email directly, view it on GitHub <#83 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLYYRJCL6S4I3LELMZW5O3ZDTPHVAVCNFSM6AAAAABIDDQX36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRVGQ3TMNBWG4>. You are receiving this because you authored the thread.Message ID: ***@***.***>

0 replies

bertradio · 2024-05-22T20:01:18Z

bertradio
May 22, 2024
Author

The directory in the notification is the directory to which I have changed in yazi.

…

On Wed, May 22, 2024, at 21:59, Bert wrote: Attached is my yazi config. When I enter yazi and change directory then exit it does not change the cwd. Instead I get this notification. .{ [2] = "/home/bert/.config/nvim" } On Wed, May 22, 2024, at 20:24, Mika Vilpas wrote: > > > Ok, I have something that might work for you in the PR autolinked above. > > Here's how I set it up in my config: > > { > -- "mikavilpas/yazi.nvim", > dir = "~/git/yazi.nvim/", > dependencies = { > "nvim-lua/plenary.nvim", > }, > event = "VeryLazy", > keys = { > { > "<up>", > function() > require("yazi").yazi() > end, > desc = "Open the file manager", > }, > { > "<s-up>", > function() > require("yazi").yazi(nil, vim.fn.getcwd()) > end, > desc = "Open the file manager in the cwd", > }, > }, > ***@***.*** YaziConfig > opts = { > open_for_directories = true, > enable_mouse_support = true, > -- log_level = vim.log.levels.DEBUG, > ***@***.*** disable-next-line: missing-fields > hooks = { > yazi_closed_successfully = function(chosen_file, config, state) > vim.notify(vim.inspect({ chosen_file, state.last_directory.filename })) > end, > }, > }, > } > Basically, you can use the `yazi_closed_successfully` hook. I added a new parameter for information that is known when yazi has closed. > > Do you know how to try that out? You can add Cto your lazy.nvim spec if you're using that. > > > > —m > Reply to this email directly, view it on GitHub <#83 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLYYRJCL6S4I3LELMZW5O3ZDTPHVAVCNFSM6AAAAABIDDQX36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRVGQ3TMNBWG4>. > You are receiving this because you authored the thread.Message ID: ***@***.***> > > *Attachments:* • yazi.lua

0 replies

mikavilpas · 2024-05-23T05:45:39Z

mikavilpas
May 23, 2024
Maintainer

Ok, it seems to be working then.
Try this:

      hooks = {
        yazi_closed_successfully = function(chosen_file, config, state)
          if state.last_directory.filename then
            vim.notify("Changing directory to " .. state.last_directory.filename)
            vim.fn.chdir(state.last_directory.filename)
          end
        end,
      },

You can remove the notifying once you have made sure it works.

0 replies

bertradio · 2024-05-23T06:33:52Z

bertradio
May 23, 2024
Author

Works now. Cool! Only issue is that it changes cwd if I open a file from yazi. Not sure if this is what I want. I do want it to change directory if I exit yazi without picking a file. What behavior do you think is best?

…

On Thu, May 23, 2024, at 07:46, Mika Vilpas wrote: Ok, it seems to be working then. Try this: hooks = { yazi_closed_successfully = function(chosen_file, config, state) if state.last_directory.filename then vim.notify("Changing directory to " .. state.last_directory.filename) vim.fn.chdir(state.last_directory.filename) end end, }, You can remove the notifying once you have made sure it works. — Reply to this email directly, view it on GitHub <#83 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLYYROJTXSXQRGMECT7FHTZDV7BRAVCNFSM6AAAAABIDDQX36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRWGI4DCNRXHA>. You are receiving this because you authored the thread.Message ID: ***@***.***>

0 replies

bertradio · 2024-05-23T06:44:49Z

bertradio
May 23, 2024
Author

I've played with this awhile and I think the behavior I would like is to change CWD if I exit yazi without opening a file. If I open a file and yazi exits, I would not want to change the cwd. Does this make sense? Is it an easy change?

…

On Thu, May 23, 2024, at 08:33, Bert wrote: Works now. Cool! Only issue is that it changes cwd if I open a file from yazi. Not sure if this is what I want. I do want it to change directory if I exit yazi without picking a file. What behavior do you think is best? On Thu, May 23, 2024, at 07:46, Mika Vilpas wrote: > > > > > Ok, it seems to be working then. > Try this: > > > hooks = { > yazi_closed_successfully = function(chosen_file, config, state) > if state.last_directory.filename then > vim.notify("Changing directory to " .. state.last_directory.filename) > vim.fn.chdir(state.last_directory.filename) > end > end, > }, > You can remove the notifying once you have made sure it works. > > > > — > Reply to this email directly, view it on GitHub <#83 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLYYROJTXSXQRGMECT7FHTZDV7BRAVCNFSM6AAAAABIDDQX36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRWGI4DCNRXHA>. > You are receiving this because you authored the thread.Message ID: ***@***.***> > >

0 replies

mikavilpas · 2024-05-23T06:50:14Z

mikavilpas
May 23, 2024
Maintainer

Ah, good point! I think this does what you want:

      ---@diagnostic disable-next-line: missing-fields
      hooks = {
        yazi_closed_successfully = function(chosen_file, config, state)
          if chosen_file == nil and state.last_directory.filename then
            vim.notify("Changing directory to " .. state.last_directory.filename)
            vim.fn.chdir(state.last_directory.filename)
          end
        end,
      },

I am thinking this could be a built in feature in yazi.nvim, but I'm not sure how I could make it happen just yet. If I come up with a way, I'll notify you via this issue, but for now that should work!

0 replies

bertradio · 2024-05-23T07:17:52Z

bertradio
May 23, 2024
Author

Perfect! How about a setting on opt for this with these options for no cwd change, cwd change always, cwd change except on file open?

…

On Thu, May 23, 2024, at 08:50, Mika Vilpas wrote: Ah, good point! I think this does what you want: ***@***.*** disable-next-line: missing-fields hooks = { yazi_closed_successfully = function(chosen_file, config, state) if chosen_file == nil and state.last_directory.filename then vim.notify("Changing directory to " .. state.last_directory.filename) vim.fn.chdir(state.last_directory.filename) end end, }, I am thinking this could be a built in feature in yazi.nvim, but I'm not sure how I could make it happen just yet. If I come up with a way, I'll notify you via this issue, but for now that should work! — Reply to this email directly, view it on GitHub <#83 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLYYRK3N6PYGUDX4S5VAGDZDWGTZAVCNFSM6AAAAABIDDQX36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRWGM2TONRWGU>. You are receiving this because you authored the thread.Message ID: ***@***.***>

0 replies

bertradio · 2024-05-23T09:38:38Z

bertradio
May 23, 2024
Author

Another idea, pass the options when yazi is called. That way one could have different keymaps for different options.

…

On Thu, May 23, 2024, at 09:17, Bert wrote: Perfect! How about a setting on opt for this with these options for no cwd change, cwd change always, cwd change except on file open? On Thu, May 23, 2024, at 08:50, Mika Vilpas wrote: > > > Ah, good point! I think this does what you want: > > ***@***.*** disable-next-line: missing-fields > hooks = { > yazi_closed_successfully = function(chosen_file, config, state) > if chosen_file == nil and state.last_directory.filename then > vim.notify("Changing directory to " .. state.last_directory.filename) > vim.fn.chdir(state.last_directory.filename) > end > end, > }, > I am thinking this could be a built in feature in yazi.nvim, but I'm not sure how I could make it happen just yet. If I come up with a way, I'll notify you via this issue, but for now that should work! > > > > — > Reply to this email directly, view it on GitHub <#83 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLYYRK3N6PYGUDX4S5VAGDZDWGTZAVCNFSM6AAAAABIDDQX36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRWGM2TONRWGU>. > You are receiving this because you authored the thread.Message ID: ***@***.***> > >

0 replies

mikavilpas · 2024-05-24T15:17:45Z

mikavilpas
May 24, 2024
Maintainer

Those are good suggestions, thanks. I'd like to keep this open for now. They can probably be implemented, but so many things are open about the near future in terms of possibilities that I don't know what to do yet.

0 replies

bertradio · 2024-05-24T15:32:05Z

bertradio
May 24, 2024
Author

Thank you so much for what you've already done. Works great for me. As for the rest, not critical... maybe some day/

…

On Fri, May 24, 2024, at 17:18, Mika Vilpas wrote: Those are good suggestions, thanks. I'd like to keep this open for now. They can probably be implemented, but so many things are open about the near future in terms of possibilities that I don't know what to do yet. — Reply to this email directly, view it on GitHub <#83 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLYYRLQLNBPKKE3IWXVZ33ZD5K27AVCNFSM6AAAAABIDDQX36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRZG44TQMRXGI>. You are receiving this because you authored the thread.Message ID: ***@***.***>

0 replies

elsesiy · 2024-10-16T06:47:19Z

elsesiy
Oct 16, 2024

Hi @mikavilpas, thank you so much for the great plugin. I'm using it every day!

Commenting here since the yazi_closed_successfully hook described above was working well until I recently updated from 8bd164d to 5199400 when it stopped and is now behaving very odd.

# lazy install config
	{
		"mikavilpas/yazi.nvim",
		dependencies = {
			"nvim-lua/plenary.nvim",
		},
		event = "VeryLazy",
		keys = {
			{
				"-",
				function()
					require("yazi").yazi()
				end,
				desc = "Open the file manager",
			},
			{
				"<leader>cw",
				function()
					require("yazi").yazi(nil, vim.fn.getcwd())
				end,
				desc = "Open the file manager in nvim's working directory",
			},
		},
		opts = {
			open_for_directories = true,
			hooks = {
				--- @diagnostic disable: unused-local
				yazi_closed_successfully = function(chosen_file, config, state)
					-- changes cwd when navigating in yazi without selecting a file
					if chosen_file == nil and state.last_directory.filename then
						vim.fn.chdir(state.last_directory.filename)
					end
				end,
			},
		},
	},

An arbitrary example using the following folder structure:

|- GitHub
   |- mydir.git (worktree)
       |- master
           |- adir
              |- afile

Issue 1:
Opening vim in mydir.git and navigating to afile does not change the cwd to adir as expected any longer but to the parent of mydir.git which is GitHub. I confirmed this by adding a simple print("last dir " .. state.last_directory.filename) which yields last dir /Users/elsesiy/Developer/GitHub.

Issue 2:
Once I select afile, open yazi via - and exit yazi via q, the dir is set correctly to adir. However, any dir change after that does not change cwd any longer. My guess is that chose_file does not reset anymore.

Was there any intended breakage that I missed or is this indeed unexpected behavior?
Thank you for taking a look!

4 replies

mikavilpas Oct 16, 2024
Maintainer

I found a bug with the current implementation. I think I was able to fix it here #519

Could you try this again when that fix is included? It might not fix everything, but I would like to know if it changes things for you, if possible.

Thanks for the detailed question btw, it's really helpful.

elsesiy Oct 17, 2024

Thank you for the quick reply @mikavilpas, I tried the patch and it does seem to fix it partially. The behavior is now that once I opened a file in adir and reopen yazi and immediately close it, the cwd gets updated. However, it does not work without having opened afile prior and it also does not change when just navigating around to a different dir/file without opening it.

Working sequence

Open nvim in mydir.git (cwd: mydir.git)
- (open yazi) -> navigate to adir -> navigate to afile (file enter, in my case via l)
- (open yazi) -> q (quit yazi) -> cwd: adir

Let me know if there's any further debug information I can provide and thanks again for taking a look!

mikavilpas Oct 17, 2024
Maintainer

Thanks, this helped me and I found a new bug 🙂 It has been fixed here: #523

Could you see if this solves the issue?

elsesiy Oct 18, 2024

Thank you @mikavilpas, looks like things are back to normal and both issues have been resolved with the latest iteration 🎉

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Is there a way to change the cwd in nvim when yazi exits? #95

{{title}}

Replies: 17 comments 4 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

Is there a way to change the cwd in nvim when yazi exits? #95

bertradio May 22, 2024

Replies: 17 comments · 4 replies

mikavilpas May 22, 2024 Maintainer

mikavilpas May 22, 2024 Maintainer

bertradio May 22, 2024 Author

mikavilpas May 22, 2024 Maintainer

bertradio May 22, 2024 Author

mikavilpas May 22, 2024 Maintainer

bertradio May 22, 2024 Author

bertradio May 22, 2024 Author

mikavilpas May 23, 2024 Maintainer

bertradio May 23, 2024 Author

bertradio May 23, 2024 Author

mikavilpas May 23, 2024 Maintainer

bertradio May 23, 2024 Author

bertradio May 23, 2024 Author

mikavilpas May 24, 2024 Maintainer

bertradio May 24, 2024 Author

elsesiy Oct 16, 2024

mikavilpas Oct 16, 2024 Maintainer

elsesiy Oct 17, 2024

mikavilpas Oct 17, 2024 Maintainer

elsesiy Oct 18, 2024

bertradio
May 22, 2024

Replies: 17 comments 4 replies

mikavilpas
May 22, 2024
Maintainer

mikavilpas
May 22, 2024
Maintainer

bertradio
May 22, 2024
Author

mikavilpas
May 22, 2024
Maintainer

bertradio
May 22, 2024
Author

mikavilpas
May 22, 2024
Maintainer

bertradio
May 22, 2024
Author

bertradio
May 22, 2024
Author

mikavilpas
May 23, 2024
Maintainer

bertradio
May 23, 2024
Author

bertradio
May 23, 2024
Author

mikavilpas
May 23, 2024
Maintainer

bertradio
May 23, 2024
Author

bertradio
May 23, 2024
Author

mikavilpas
May 24, 2024
Maintainer

bertradio
May 24, 2024
Author

elsesiy
Oct 16, 2024

mikavilpas Oct 16, 2024
Maintainer

mikavilpas Oct 17, 2024
Maintainer