[BE][Easy] enable ruff rule PIE790: unnecessary pass statement (pytorch#133200)

This PR removes unnecessary `pass` statement. This is semanticly safe because the bytecode for the Python code does not change.

Note that if there is a docstring in the function, a empty function does not need a `pass` statement as placeholder.

Pull Request resolved: pytorch#133200
Approved by: https://github.com/malfet, https://github.com/eqy, https://github.com/kit1980

Author: XuehaiPan

.github/scripts/gitutils.py

@@ -445,7 +445,6 @@ def wrapper(*args: List[Any], **kwargs: Dict[str, Any]) -> T:
                     print(
                         f'Attempt {idx} of {num_retries} to call {f.__name__} failed with "{e}"'
                     )
-                    pass
             return cast(T, rc)
 
         return wrapper

benchmarks/functional_autograd_benchmark/torchvision_models.py

@@ -402,8 +402,6 @@ class FCN(_SimpleSegmentationModel):
         aux_classifier (nn.Module, optional): auxiliary classifier used during training
     """
 
-    pass
-
 
 class FCNHead(nn.Sequential):
     def __init__(self, in_channels, channels):

pyproject.toml

@@ -108,6 +108,7 @@ select = [
     "NPY",
     "PERF",
     "PGH004",
+    "PIE790",
     "PIE794",
     "PIE800",
     "PIE804",

test/cpp/jit/tests_setup.py

@@ -18,7 +18,6 @@ class FileSetup:
     def shutdown(self):
         if os.path.exists(self.path):
             os.remove(self.path)
-            pass
 
 
 class EvalModeForLoadedModule(FileSetup):

test/distributed/_composable/test_replicate_with_compiler.py

@@ -76,8 +76,6 @@ class MultiProcessInductorTestCase(MultiProcessTestCase, InductorTestCase):
     to handle isolation of the inductor cache dir.
     """
 
-    pass
-
 
 class ReplicateTest(MultiProcessInductorTestCase):
     @property

test/distributed/elastic/rendezvous/rendezvous_backend_test.py

@@ -29,7 +29,6 @@ class RendezvousBackendTestMixin(ABC):
     @abstractmethod
     def _corrupt_state(self) -> None:
         """Corrupts the state stored in the backend."""
-        pass
 
     def _set_state(
         self, state: bytes, token: Optional[Any] = None

test/distributed/fsdp/test_fsdp_comm_hooks.py

@@ -94,7 +94,6 @@ def custom_reduce_scatter(self, output, input, group=None):
         of a flattened tensor to all processes in a group.
         Currently a no-op.
         """
-        pass
 
     def dummy_hook_for_sharded_fsdp(
         self, state: DummyState, grad: torch.Tensor, output: torch.Tensor

test/distributed/test_c10d_gloo.py

@@ -2177,7 +2177,6 @@ def tearDown(self):
             os.remove(self.file.name)
         except OSError as e:
             print(str(e))
-            pass
 
     @requires_gloo()
     def test_single_dtype_single_bucket(self):

test/export/test_converter.py

@@ -1389,7 +1389,6 @@ def fuse_model(self):
                 torch.ao.quantization.fuse_modules(
                     self, [["conv2", "relu"]], inplace=True
                 )
-                pass
 
         with override_quantized_engine("qnnpack"):
             model = Standalone()

test/inductor/test_compiled_autograd.py

@@ -416,7 +416,6 @@ def inner_compiler(gm_, example_inputs_):
                 if is_bwd:
                     # should be boxed inputs
                     assert len(placeholders) == 1
-                    pass
                 else:
                     assert len(placeholders) > 1
 

test/inductor/test_flex_attention.py

@@ -1162,7 +1162,6 @@ def forward(a, mask):
             def setup_context(ctx, inputs, output):
                 _, mask = inputs
                 ctx.mark_non_differentiable(mask)
-                pass
 
             @staticmethod
             def backward(ctx, i):

test/inductor/test_group_batch_fusion.py

@@ -19,7 +19,6 @@
     has_fbgemm = True
 except Exception:
     has_fbgemm = False
-    pass
 
 requires_cuda = unittest.skipUnless(HAS_CUDA, "requires cuda")
 

test/inductor/test_perf.py

@@ -84,7 +84,6 @@ def TI(*size, mx=10, dtype=torch.int32, device=DEVICE):
 
 class TestCase(InductorTestCase):
     device = DEVICE
-    pass
 
 
 class NumBytesMetricTests(TestCase):

test/jit/test_backends.py

@@ -114,19 +114,16 @@ def test_execution(self):
         """
         Stub for correctness tests.
         """
-        pass
 
     def test_save_load(self):
         """
         Stub for serialization tests.
         """
-        pass
 
     def test_errors(self):
         """
         Stub for testing error checking.
         """
-        pass
 
 
 class BasicModuleTest(JitBackendTestCase):
@@ -559,13 +556,11 @@ def test_execution(self):
         """
         Stub for correctness tests.
         """
-        pass
 
     def test_errors(self):
         """
         Stub for testing error checking.
         """
-        pass
 
 
 class BasicModuleTestWithCompiler(JitBackendTestCaseWithCompiler):

test/jit/test_class_type.py

@@ -962,7 +962,6 @@ def __bool__(self):
             def test():
                 if BadBool():
                     print(1)
-                    pass
 
     def test_init_compiled_first(self):
         @torch.jit.script  # noqa: B903

test/jit/test_module_interface.py

@@ -160,7 +160,7 @@ def forward(self, input):
                 # type: (Tensor) -> Tensor
                 r"""stuff 1"""
                 r"""stuff 2"""
-                pass
+                pass  # noqa: PIE790
                 r"""stuff 3"""
 
         class TestModule(nn.Module):

test/scripts/cuda_memcheck_common.py

@@ -5,8 +5,6 @@
 class ParseError(Exception):
     """Whenever the simple parser is unable to parse the report, this exception will be raised"""
 
-    pass
-
 
 class Report:
     """A report is a container of errors, and a summary on how many errors are found"""

test/test_autograd.py

@@ -12515,7 +12515,6 @@ def functional_op(x):
                 )
                 with self.assertRaisesRegex(RuntimeError, err_msg):
                     out.add_(2)
-                pass
             else:
                 out.add_(2)
 
@@ -12611,7 +12610,6 @@ def run_test(fn):
                     err_msg = "A view was created in inference mode and is being modified inplace"
                     with self.assertRaisesRegex(RuntimeError, err_msg):
                         fn(view_out)
-                    pass
                 else:
                     fn(view_out)
 
@@ -12632,7 +12630,6 @@ def run_test(fn):
                     err_msg = "A view was created in inference mode and its base or another view "
                     with self.assertRaisesRegex(RuntimeError, err_msg):
                         view_out.grad_fn
-                    pass
                 else:
                     view_out.grad_fn
 

test/test_mobile_optimizer.py

@@ -427,7 +427,6 @@ def forward(self, x):
 
             def fuse_model(self):
                 torch.ao.quantization.fuse_modules(self, [['conv2', 'relu']], inplace=True)
-                pass
 
         class Child(nn.Module):
             def __init__(self) -> None:

test/test_tensorexpr_pybind.py

@@ -197,7 +197,6 @@ def test_kernel_shape_prop(self):
             # Graph doesn't have shape info for inputs => compilation should
             # fail
             exception_thrown = True
-            pass
         assert exception_thrown
 
         # Inject shape info and try compiling again
@@ -227,7 +226,6 @@ def forward(self, x, y):
             kernel = te.TensorExprKernel(graph)
         except RuntimeError:
             exception_thrown = True
-            pass
         assert exception_thrown
 
         # Try injecting shape info for graph inputs
@@ -239,7 +237,6 @@ def forward(self, x, y):
         except RuntimeError:
             # Graph has a 'self' argument for which we can't set shapes
             exception_thrown = True
-            pass
         assert exception_thrown
 
         # Remove 'self' argument and try annotating shapes one more time

test/test_testing.py

@@ -813,7 +813,6 @@ class UnexpectedException(Exception):
         the test should mock a component to raise this instead of the regular behavior. We avoid using a builtin
         exception here to avoid triggering possible handling of them.
         """
-        pass
 
     @unittest.mock.patch("torch.testing._comparison.TensorLikePair.__init__", side_effect=UnexpectedException)
     def test_unexpected_error_originate(self, _):

tools/linter/adapters/flake8_linter.py

@@ -132,7 +132,6 @@ def _test_results_re() -> None:
     {'file': 'file.py', 'line': '8', 'column': '-10', 'code': 'W605',
      'message': "invalid escape sequence '/'"}
     """
-    pass
 
 
 def _run_command(

tools/testing/target_determination/heuristics/interface.py

@@ -329,4 +329,3 @@ def get_prediction_confidence(self, tests: list[str]) -> TestPrioritizations:
         positive means run, 0 means no idea, and magnitude = how confident the
         heuristic is. Used by AggregatedHeuristicsRankings.
         """
-        pass

torch/_awaits/__init__.py

@@ -51,4 +51,3 @@ class _Await(torch._C._Await, Generic[W], metaclass=_PyAwaitMeta):
     In eager mode ``Await[W]`` can be used as ``W`` i.e. attributes of W can be called on ``Await[W]``,
     ``_awaitable_wait()`` call will be transparently added.
     """
-    pass

torch/_dynamo/debug_utils.py

@@ -719,7 +719,6 @@ def forward(self, primals_1: "f32[1001, 6]", primals_2: "f32[s0]", primals_3: "S
 
     class TensorContainer:
         "Container for tensors as attributes"
-        pass
 
     # Dictionary for tensors from annotations
     kwargs: Dict[str, Any] = {}

torch/_dynamo/decorators.py

@@ -142,7 +142,6 @@ def fn(a):
 @_disallow_in_graph_helper(throw_if_not_allowed=False)
 def graph_break():
     """Force a graph break"""
-    pass
 
 
 def forbid_in_graph(fn):
@@ -348,7 +347,6 @@ def _allow_in_graph_einops():
         )
 
         # einops > 0.6.1 will call the op registration logic as it is imported.
-        pass
     except ImportError:
         # einops <= 0.6.1
         allow_in_graph(einops.rearrange)

torch/_dynamo/repro/after_aot.py

@@ -323,7 +323,6 @@ def dump_compiler_graph_state(gm, args, compiler_name, *, accuracy=None):
             BuckTargetWriter(file_name).write()
     except OSError:
         log.warning("No write permissions for %s", repro_path)
-        pass
 
 
 # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ #

torch/_dynamo/variables/builder.py

@@ -1543,7 +1543,6 @@ def wrap_numpy_ndarray(self, value):
                 # One can not easily make nditer elements writable,
                 # but warning is not the end of the world
                 assert isinstance(value.base, np.nditer)
-                pass
 
         try:
             tensor_value = _util._try_convert_to_tensor(value)

torch/_dynamo/variables/dicts.py

@@ -657,8 +657,6 @@ class DataClassVariable(ConstDictVariable):
     Keeping since we wish to support dataclasses in general in the future
     """
 
-    pass
-
 
 class CustomizedDictVariable(ConstDictVariable):
     @staticmethod

torch/_dynamo/variables/misc.py

@@ -423,8 +423,6 @@ def reconstruct(self, codegen):
 class InspectParameterVariable(VariableTracker):
     """This is not implemented, if used will graph break."""
 
-    pass
-
 
 class InspectBoundArgumentsVariable(VariableTracker):
     """represents inspect.signature(...).bind(...)"""

torch/_export/passes/replace_with_hop_pass_util.py

@@ -68,7 +68,6 @@ def set_hoo_node_meta(call_func_node):
                     output_node = output_args[idx]
                     get_item_node._rename(output_node.name)
                     get_item_node.meta = output_node.meta
-                    pass
 
             elif isinstance(output_args, torch.fx.Node):
                 call_func_node = graph.create_node(

torch/_export/verifier.py

@@ -149,7 +149,6 @@ def check_additional(self, gm: GraphModule) -> None:
         """
         Additional checks that are specific to some dialects.
         """
-        pass
 
     @final
     def check(self, ep: "ExportedProgram") -> None:

torch/_functorch/_aot_autograd/autograd_cache.py

@@ -275,8 +275,6 @@ class CompiledForward(FXGraphCacheLoadable):
     Cacheable entry for a forward function
     """
 
-    pass
-
 
 @dataclass
 class CompiledBackward(FXGraphCacheLoadable):

torch/_inductor/autoheuristic/autoheuristic.py

@@ -42,8 +42,6 @@ class InconsistentMetadata(Exception):
     not match the metadata it would store if the file didn't exist.
     """
 
-    pass
-
 
 class AutoHeuristic:
     """

torch/_inductor/codecache.py

@@ -708,8 +708,6 @@ class BypassFxGraphCache(Exception):
     Exception to indicate that the FxGraphCache should be bypassed.
     """
 
-    pass
-
 
 class FxGraphHashDetails:
     """

torch/_inductor/codegen/simd.py

@@ -397,7 +397,6 @@ def finalize_indexing(self, indices: Sequence[sympy.Expr]):
         Hook called right before codegen with every index that will be
         used in the fused kernel.
         """
-        pass
 
     def store_reduction(self, name: str, index: sympy.Expr, value: CSEVariable):
         prior = self.inside_reduction

torch/_inductor/codegen/wrapper.py

@@ -358,7 +358,6 @@ def plan(self, state: MemoryPlanningState) -> MemoryPlanningLine:
 
     def codegen(self, code: IndentedBuffer) -> None:
         """Second pass to output code"""
-        pass
 
     def __str__(self) -> str:
         """

torch/_inductor/cudagraph_trees.py

@@ -720,7 +720,6 @@ class OutputAliasInfo:
 
 class _UnaliasedStorage(OutputAliasInfo):
     "Singleton to mark that the graph output constructs a new alias or is None"
-    pass
 
 
 UnaliasedStorage = _UnaliasedStorage()
@@ -1546,7 +1545,6 @@ def remove_path_cached_tensors(self) -> None:
     def clear_path_state(self) -> None:
         "Clear the path state in this current executing node"
         # this doesnt actually do anything right now, leaving it as placeholder
-        pass
 
     @staticmethod
     def _tensor_metadata(