Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration caching failure in Android projects #839

Open
4 of 5 tasks
ILikeYourHat opened this issue Feb 1, 2023 · 1 comment
Open
4 of 5 tasks

Configuration caching failure in Android projects #839

ILikeYourHat opened this issue Feb 1, 2023 · 1 comment

Comments

@ILikeYourHat
Copy link

ILikeYourHat commented Feb 1, 2023

About this issue

I've found an issue with caching in AboutLibrary plugin, a pretty serious I think.

Details

The recipe for disaster:

  • create an Android project
  • add this plugin to it, without any additional configuration (note that registerAndroidTasks is set to true in this case)
  • create at least one additional Android module, and make it a debugImplementation dependency in the main module
  • make sure to include some third-party dependencies in both modules (like AppCompat, nothing fancy)
  • add those lines to thegradle.properties file: org.gradle.configureondemand=true, org.gradle.unsafe.configuration-cache=true
  • try to execute ./gradlew :app:assembleRelease

Expected outcome:

  • a successful build

Actual outcome:

FAILURE: Build failed with an exception.

* What went wrong:
An exception occurred applying plugin request [id: 'com.android.library']
> Failed to apply plugin 'com.android.internal.library'.
   > Gradle#projectsEvaluated(Action) on build 'AboutLibrariesTestApp' cannot be executed in the current context.

So, in other words: assembling release application is broken.

I've prepared a sample application with this issue, reduced to the bare minimum needed to reproduce it:
https://github.com/ILikeYourHat/AboutLibrariesTestApp

Checklist

@mikepenz
Copy link
Owner

Thank you very much for the report @ILikeYourHat

timusus added a commit to timusus/Shuttle2 that referenced this issue Nov 27, 2023
This resolves a crash when attempting to open the licenses dialog. Due to an issue with the AboutLibraries plugin, the libraries are currently empty.

See mikepenz/AboutLibraries#839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants