Refactor email notifications system

Consolidated notification email functions and refactored the email sending logic to use a centralized emailer utility. Removed outdated email templates and added better support for email frequency configurations in notification settings, with new components for user preferences management. This improves code maintainability and ensures more robust email notifications.

Took 13 minutes

Author: mikepsinn

app/api/cron/petition-summaries/route.ts

@@ -1,22 +1,32 @@
-import { NextResponse } from 'next/server'
-import { sendDailySummaries, sendWeeklySummaries } from '@/lib/notifications/petition-summary'
+import { logger } from "@/lib/logger"
+import {
+  sendDailySummaries,
+  sendWeeklySummaries,
+} from "@/lib/notifications/petition-notifications"
 
-export const runtime = 'edge'
+const log = logger.forService("cron-petition-summaries")
 
-export async function GET(request: Request) {
+export async function GET() {
   try {
-    const { searchParams } = new URL(request.url)
-    const type = searchParams.get('type')
+    log.info("Starting petition summary notifications")
 
-    if (type === 'daily') {
-      await sendDailySummaries()
-    } else if (type === 'weekly') {
-      await sendWeeklySummaries()
-    }
+    await Promise.all([sendDailySummaries(), sendWeeklySummaries()])
 
-    return NextResponse.json({ success: true })
+    log.info("Completed petition summary notifications")
+
+    return new Response("OK", { status: 200 })
   } catch (error) {
-    console.error('Cron job failed:', error)
-    return NextResponse.json({ error: 'Failed to process summaries' }, { status: 500 })
+    log.error("Failed to send petition summaries", {
+      error:
+        error instanceof Error
+          ? {
+              name: error.name,
+              message: error.message,
+              stack: error.stack,
+            }
+          : { message: String(error) },
+    })
+
+    return new Response("Internal Server Error", { status: 500 })
   }
-} 
+}

app/petitions/components/NotificationSettings.tsx

@@ -0,0 +1,111 @@
+"use client"
+
+import { useState } from "react"
+import { EmailFrequency } from "@prisma/client"
+import { useSession } from "next-auth/react"
+
+import { Button } from "@/components/ui/button"
+import { Select } from "@/components/ui/select"
+import { Switch } from "@/components/ui/switch"
+import { useToast } from "@/components/ui/use-toast"
+
+interface NotificationSettingsProps {
+  petitionId: string
+  initialSettings?: {
+    notifyOnComment: boolean
+    notifyOnMilestone: boolean
+    notifyOnUpdate: boolean
+    notifyOnSignature: boolean
+    emailFrequency: EmailFrequency
+  }
+  onUpdate: (
+    petitionId: string,
+    settings: {
+      notifyOnComment: boolean
+      notifyOnMilestone: boolean
+      notifyOnUpdate: boolean
+      notifyOnSignature: boolean
+      emailFrequency: EmailFrequency
+    }
+  ) => Promise<void>
+}
+
+export function NotificationSettings({
+  petitionId,
+  initialSettings,
+  onUpdate,
+}: NotificationSettingsProps) {
+  const { data: session } = useSession()
+  const { toast } = useToast()
+  const [loading, setLoading] = useState(false)
+
+  const [notifications, setNotifications] = useState(
+    initialSettings
+      ? initialSettings.notifyOnComment &&
+          initialSettings.notifyOnMilestone &&
+          initialSettings.notifyOnUpdate &&
+          initialSettings.notifyOnSignature
+      : true
+  )
+
+  const [emailFrequency, setEmailFrequency] = useState<EmailFrequency>(
+    initialSettings?.emailFrequency || "INSTANT"
+  )
+
+  const handleUpdate = async () => {
+    setLoading(true)
+    try {
+      await onUpdate(petitionId, {
+        notifyOnComment: notifications,
+        notifyOnMilestone: notifications,
+        notifyOnUpdate: notifications,
+        notifyOnSignature: notifications,
+        emailFrequency,
+      })
+      toast({
+        title: "Success",
+        description: "Notification settings updated",
+      })
+    } catch (error) {
+      console.error("Failed to update notification settings:", error)
+      toast({
+        title: "Error",
+        description: "Failed to update notification settings",
+        variant: "destructive",
+      })
+    } finally {
+      setLoading(false)
+    }
+  }
+
+  if (!session) return null
+
+  return (
+    <div className="space-y-4 rounded-lg bg-white p-4 shadow">
+      <h3 className="mb-4 text-lg font-semibold">Notification Settings</h3>
+
+      <div className="flex items-center justify-between">
+        <label className="font-medium">Notifications</label>
+        <Switch checked={notifications} onCheckedChange={setNotifications} />
+      </div>
+
+      {notifications && (
+        <div className="flex items-center justify-between">
+          <label className="font-medium">Email Frequency</label>
+          <Select
+            value={emailFrequency}
+            onValueChange={(value: EmailFrequency) => setEmailFrequency(value)}
+          >
+            <option value="INSTANT">Instant</option>
+            <option value="DAILY">Daily Digest</option>
+            <option value="WEEKLY">Weekly Digest</option>
+          </Select>
+        </div>
+      )}
+
+      <Button onClick={handleUpdate} disabled={loading} className="w-full">
+        {loading ? "Saving..." : "Save Settings"}
+      </Button>
+    </div>
+  )
+}