You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Video standalone filter is nice for starters.
But the issue is that you need to also maintain those video links/URLs/code all the time.
It could be beneficial to let a dedicated library take care of that
E.g. https://github.com/dereuromark/media-embed
To have BC and the choice we could add an optional
MediaEmbedVideoFilter which only adds the dependency as require-dev for testing
If you want to use you add the real dependency, otherwise no harm.
To have BC and the choice we could add an optional
Why to not use it on VideoFilter totally transparently to supports more providers.
Does current VideoFilter interface can support all providers?
Does your library is enough extendible in order to adapt VideoFilter interface to media-embed lib?
=> So there will be no BC break but more provider support.
Worth porting into, or should this be kept outside as own package shipping?
The Video standalone filter is nice for starters.
But the issue is that you need to also maintain those video links/URLs/code all the time.
It could be beneficial to let a dedicated library take care of that
E.g. https://github.com/dereuromark/media-embed
To have BC and the choice we could add an optional
MediaEmbedVideoFilter which only adds the dependency as require-dev for testing
If you want to use you add the real dependency, otherwise no harm.
The working code can be seen here:
https://github.com/dereuromark/cakephp-markup/blob/master/src/Bbcode/Decoda/VideoFilter.php
What do you think?
Worth porting into, or should this be kept outside as own package shipping?
The text was updated successfully, but these errors were encountered: