removed unreachable safety checks for code clarity

milosdjurica · milosdjurica · commit ffd9bd86d3e6 · 2025-04-06T17:02:32.000+02:00
diff --git a/src/Secp256k1Lib.sol b/src/Secp256k1Lib.sol
@@ -72,9 +72,6 @@ library Secp256k1 {
         if (x1 == x2) {
             if (y1 == y2) return doublePointUnchecked(x1, y1); // Doubling a point
             if ((y1 + y2) % p == 0) return (0, 0); // Point at infinity
-            // ! This checks are unreachable if the points are valid. Added here just as a safety measure, as they don't use gas, since they should never be reached.
-            if (!isOnCurve(x1, y1)) revert Secp256k1__InvalidPoint(x1, y1);
-            if (!isOnCurve(x2, y2)) revert Secp256k1__InvalidPoint(x2, y2);
         }
 
         // ! Calculate slope

Original file line number	Diff line number	Diff line change
`@@ -72,9 +72,6 @@ library Secp256k1 {`
`72`	`72`	`if (x1 == x2) {`
`73`	`73`	`if (y1 == y2) return doublePointUnchecked(x1, y1); // Doubling a point`
`74`	`74`	`if ((y1 + y2) % p == 0) return (0, 0); // Point at infinity`
`75`		`- // ! This checks are unreachable if the points are valid. Added here just as a safety measure, as they don't use gas, since they should never be reached.`
`76`		`- if (!isOnCurve(x1, y1)) revert Secp256k1__InvalidPoint(x1, y1);`
`77`		`- if (!isOnCurve(x2, y2)) revert Secp256k1__InvalidPoint(x2, y2);`
`78`	`75`	`}`
`79`	`76`
`80`	`77`	`// ! Calculate slope`