Skip to content

Commit bf2c27d

Browse files
authored
fix: [cherry-pick]Remove the dependency of server_name to others (#1981)
See also: #1962 Signed-off-by: yangxuan <[email protected]>
1 parent 4b9741a commit bf2c27d

File tree

1 file changed

+20
-20
lines changed

1 file changed

+20
-20
lines changed

pymilvus/client/grpc_handler.py

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -195,36 +195,36 @@ def _setup_grpc_channel(self):
195195
options=opts,
196196
)
197197
else:
198-
if (
198+
if self._server_name != "":
199+
opts.append(("grpc.ssl_target_name_override", self._server_name))
200+
201+
root_cert, private_k, cert_chain = None, None, None
202+
if self._server_pem_path != "":
203+
with Path(self._server_pem_path).open("rb") as f:
204+
root_cert = f.read()
205+
elif (
199206
self._client_pem_path != ""
200207
and self._client_key_path != ""
201208
and self._ca_pem_path != ""
202-
and self._server_name != ""
203209
):
204-
opts.append(("grpc.ssl_target_name_override", self._server_name))
205-
with Path(self._client_pem_path).open("rb") as f:
206-
certificate_chain = f.read()
207-
with Path(self._client_key_path).open("rb") as f:
208-
private_key = f.read()
209210
with Path(self._ca_pem_path).open("rb") as f:
210-
root_certificates = f.read()
211-
creds = grpc.ssl_channel_credentials(
212-
root_certificates, private_key, certificate_chain
213-
)
214-
elif self._server_pem_path != "" and self._server_name != "":
215-
opts.append(("grpc.ssl_target_name_override", self._server_name))
216-
with Path(self._server_pem_path).open("rb") as f:
217-
server_pem = f.read()
218-
creds = grpc.ssl_channel_credentials(root_certificates=server_pem)
219-
else:
220-
creds = grpc.ssl_channel_credentials(
221-
root_certificates=None, private_key=None, certificate_chain=None
222-
)
211+
root_cert = f.read()
212+
with Path(self._client_key_path).open("rb") as f:
213+
private_k = f.read()
214+
with Path(self._client_pem_path).open("rb") as f:
215+
cert_chain = f.read()
216+
217+
creds = grpc.ssl_channel_credentials(
218+
root_certificates=root_cert,
219+
private_key=private_k,
220+
certificate_chain=cert_chain,
221+
)
223222
self._channel = grpc.secure_channel(
224223
self._address,
225224
creds,
226225
options=opts,
227226
)
227+
228228
# avoid to add duplicate headers.
229229
self._final_channel = self._channel
230230
if self._authorization_interceptor:

0 commit comments

Comments
 (0)