Fix rename collection raise cannot be None error (#1615)

See also: milvus-io/milvus#25872

Signed-off-by: yangxuan <[email protected]>

Author: XuanYang-cn

pymilvus/client/grpc_handler.py

@@ -356,12 +356,17 @@ def list_collections(self, timeout: Optional[float] = None):
 
     @retry_on_rpc_failure()
     def rename_collections(
-        self, old_name: str, new_db_name: str, new_name: str, timeout: Optional[float] = None
+        self,
+        old_name: str,
+        new_name: str,
+        new_db_name: str = "default",
+        timeout: Optional[float] = None,
     ):
         check_pass_param(collection_name=new_name)
-        check_pass_param(collection_name=new_db_name)
         check_pass_param(collection_name=old_name)
-        request = Prepare.rename_collections_request(old_name, new_db_name, new_name)
+        if new_db_name:
+            check_pass_param(db_name=new_db_name)
+        request = Prepare.rename_collections_request(old_name, new_name, new_db_name)
         rf = self._stub.RenameCollection.future(request, timeout=timeout)
         response = rf.result()
 

pymilvus/client/prepare.py

@@ -255,7 +255,7 @@ def show_collections_request(cls, collection_names: Optional[List[str]] = None):
         return req
 
     @classmethod
-    def rename_collections_request(cls, old_name: str, new_db_name: str, new_name: str):
+    def rename_collections_request(cls, old_name: str, new_name: str, new_db_name: str):
         return milvus_types.RenameCollectionRequest(
             oldName=old_name, newName=new_name, newDBName=new_db_name
         )

pymilvus/orm/utility.py

@@ -523,7 +523,10 @@ def rename_collection(
         >>> False
     """
     return _get_connection(using).rename_collections(
-        old_collection_name, new_db_name, new_collection_name, timeout=timeout
+        old_name=old_collection_name,
+        new_name=new_collection_name,
+        new_db_name=new_db_name,
+        timeout=timeout,
     )