Skip to content

Commit e20a390

Browse files
committed
enhance: [2.5] Add force_drop parameter to drop_role method for role deletion
Signed-off-by: SimFG <[email protected]>
1 parent e941adb commit e20a390

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

pymilvus/client/grpc_handler.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -1903,8 +1903,10 @@ def create_role(self, role_name: str, timeout: Optional[float] = None, **kwargs)
19031903
check_status(resp)
19041904

19051905
@retry_on_rpc_failure()
1906-
def drop_role(self, role_name: str, timeout: Optional[float] = None, **kwargs):
1907-
req = Prepare.drop_role_request(role_name)
1906+
def drop_role(
1907+
self, role_name: str, force_drop: bool = False, timeout: Optional[float] = None, **kwargs
1908+
):
1909+
req = Prepare.drop_role_request(role_name, force_drop=force_drop)
19081910
resp = self._stub.DropRole(req, wait_for_ready=True, timeout=timeout)
19091911
check_status(resp)
19101912

pymilvus/client/prepare.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -1478,9 +1478,9 @@ def create_role_request(cls, role_name: str):
14781478
return milvus_types.CreateRoleRequest(entity=milvus_types.RoleEntity(name=role_name))
14791479

14801480
@classmethod
1481-
def drop_role_request(cls, role_name: str):
1481+
def drop_role_request(cls, role_name: str, force_drop: bool = False):
14821482
check_pass_param(role_name=role_name)
1483-
return milvus_types.DropRoleRequest(role_name=role_name)
1483+
return milvus_types.DropRoleRequest(role_name=role_name, force_drop=force_drop)
14841484

14851485
@classmethod
14861486
def operate_user_role_request(cls, username: str, role_name: str, operate_user_role_type: Any):

pymilvus/milvus_client/milvus_client.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -1212,9 +1212,11 @@ def create_role(self, role_name: str, timeout: Optional[float] = None, **kwargs)
12121212
conn = self._get_connection()
12131213
conn.create_role(role_name, timeout=timeout, **kwargs)
12141214

1215-
def drop_role(self, role_name: str, timeout: Optional[float] = None, **kwargs):
1215+
def drop_role(
1216+
self, role_name: str, force_drop: bool = False, timeout: Optional[float] = None, **kwargs
1217+
):
12161218
conn = self._get_connection()
1217-
conn.drop_role(role_name, timeout=timeout, **kwargs)
1219+
conn.drop_role(role_name, force_drop=force_drop, timeout=timeout, **kwargs)
12181220

12191221
def describe_role(self, role_name: str, timeout: Optional[float] = None, **kwargs) -> Dict:
12201222
conn = self._get_connection()

0 commit comments

Comments
 (0)