Feat: Adds auto-command execution to SSH connections (#18)

minchodang · web-flow · commit 018757966b5a · 2025-09-23T20:36:13.000+09:00
* Feat: Adds auto command input feature for hosts

Allows users to configure auto-run commands after connecting to a host.

Prompts the user to set up auto commands during host creation.
Supports multi-line command input via an editor.
Displays the list of auto commands in the host information output.
Specifies that commands should be entered one per line.

* feat(cli): Display auto command count in host list

* feat(cli): Add autoCommands management to host edit command

* feat(connect): Add support for automatic command execution on SSH

* feat(i18n): Add Korean translation for no saved hosts message

* feat(connect): Implement auto-command execution and enhance SSH connection flow

* Refactors host display and connection logic

Improves code reusability and readability by extracting host display logic into a separate module.

Standardizes host selection across commands using a shared function.

Enhances the connection command to handle auto-run commands more effectively, combining them with an interactive bash session.

Updates translations and prompts to English
diff --git a/packages/cli/src/commands/add.ts b/packages/cli/src/commands/add.ts
@@ -2,6 +2,7 @@ import inquirer from 'inquirer';
 import chalk from 'chalk';
 import { existsSync } from 'fs';
 import { addHost, loadConfig } from '../utils/config.js';
+import { displayHostInfo } from '../utils/display.js';
 import type { SSHHost } from '../types/ssh.js';
 
 export async function addCommand() {
@@ -114,15 +115,43 @@ export async function addCommand() {
                     .filter(tag => tag.length > 0);
             },
         },
+        {
+            type: 'confirm',
+            name: 'hasAutoCommands',
+            message: 'Do you want to configure auto-run commands after connection?',
+            default: false,
+        },
+        {
+            type: 'editor',
+            name: 'autoCommandsInput',
+            message: 'Enter commands to run automatically (one per line):',
+            when: answers => answers.hasAutoCommands,
+            validate: (input: string) => {
+                if (!input || !input.trim()) {
+                    return 'Please enter at least one command.';
+                }
+                return true;
+            },
+        },
     ]);
 
+    // Process auto commands
+    let autoCommands: string[] | undefined = undefined;
+    if (answers.hasAutoCommands && answers.autoCommandsInput) {
+        autoCommands = answers.autoCommandsInput
+            .split('\n')
+            .map((cmd: string) => cmd.trim())
+            .filter((cmd: string) => cmd.length > 0);
+    }
+
     const newHost: SSHHost = {
         name: answers.name,
         host: answers.host,
         user: answers.user,
         port: answers.port,
         keyPath: answers.authMethod === 'key' ? answers.keyPath : undefined,
         usePassword: answers.authMethod === 'password',
+        autoCommands: autoCommands,
         description: answers.description,
         tags: answers.tags,
     };
@@ -132,21 +161,7 @@ export async function addCommand() {
 
         console.log();
         console.log(chalk.green('✅ Host added successfully!'));
-        console.log();
-        console.log(chalk.blue('📋 Host information:'));
-        console.log(`   ${chalk.cyan('Name:')} ${newHost.name}`);
-        console.log(`   ${chalk.cyan('Address:')} ${newHost.user}@${newHost.host}:${newHost.port}`);
-        if (newHost.keyPath) {
-            console.log(`   ${chalk.cyan('Key file:')} ${newHost.keyPath}`);
-        }
-        if (newHost.description) {
-            console.log(`   ${chalk.cyan('Description:')} ${newHost.description}`);
-        }
-        if (newHost.tags && newHost.tags.length > 0) {
-            console.log(`   ${chalk.cyan('Tags:')} ${newHost.tags.join(', ')}`);
-        }
-        console.log();
-        console.log(chalk.blue('💡 To connect:'), chalk.gray(`simple-ssh connect ${newHost.name}`));
+        displayHostInfo(newHost);
     } catch (error) {
         console.log(chalk.red('❌ Error adding host:'), error);
     }
diff --git a/packages/cli/src/commands/connect.ts b/packages/cli/src/commands/connect.ts
@@ -1,8 +1,8 @@
 import { spawn } from 'child_process';
 import inquirer from 'inquirer';
 import chalk from 'chalk';
-import ora from 'ora';
 import { loadConfig, getHost } from '../utils/config.js';
+import { createHostChoices } from '../utils/display.js';
 import type { ConnectionOptions } from '../types/ssh.js';
 
 export async function connectCommand(hostName?: string, options: ConnectionOptions = {}) {
@@ -30,10 +30,7 @@ export async function connectCommand(hostName?: string, options: ConnectionOptio
                 type: 'list',
                 name: 'selectedHost',
                 message: 'Select a host to connect:',
-                choices: config.hosts.map(host => ({
-                    name: `${chalk.cyan(host.name)} - ${host.user}@${host.host}:${host.port}${host.description ? ` (${host.description})` : ''}`,
-                    value: host.name,
-                })),
+                choices: createHostChoices(config.hosts),
             },
         ]);
 
@@ -52,23 +49,37 @@ export async function connectCommand(hostName?: string, options: ConnectionOptio
     console.log(chalk.blue(`🔗 Connecting to ${targetHost.name}...`));
     console.log(chalk.gray(`   ${user}@${targetHost.host}:${port}`));
 
-    const spinner = ora('Attempting SSH connection...').start();
-
     // Build SSH command
-    const sshArgs = ['-p', port.toString(), `${user}@${targetHost.host}`];
+    const sshArgs = ['-p', port.toString()];
 
     // Add key file if specified
     if (targetHost.keyPath) {
         sshArgs.unshift('-i', targetHost.keyPath);
     }
 
+    // Check for auto commands
+    const hasAutoCommands = targetHost.autoCommands && targetHost.autoCommands.length > 0;
+
+    if (hasAutoCommands) {
+        console.log(chalk.blue(`🤖 Auto commands configured (${targetHost.autoCommands!.length} commands):`));
+        targetHost.autoCommands!.forEach((cmd, index) => {
+            console.log(`   ${chalk.dim(`${index + 1}.`)} ${chalk.yellow(cmd)}`);
+        });
+        console.log();
+
+        // Combine auto commands and add bash for interactive session
+        const commandString = targetHost.autoCommands!.join(' && ') + '; bash';
+        sshArgs.push(`${user}@${targetHost.host}`, commandString);
+    } else {
+        // Regular interactive connection
+        sshArgs.push(`${user}@${targetHost.host}`);
+    }
+
     // Show password prompt info
     if (targetHost.usePassword) {
         console.log(chalk.yellow('💡 This host uses password authentication. Please enter password when prompted.'));
     }
 
-    spinner.stop();
-
     console.log(chalk.green(`✅ Starting SSH connection...`));
     console.log(chalk.gray(`Command: ssh ${sshArgs.join(' ')}`));
     console.log();
diff --git a/packages/cli/src/commands/edit.ts b/packages/cli/src/commands/edit.ts
@@ -2,6 +2,7 @@ import inquirer from 'inquirer';
 import chalk from 'chalk';
 import { existsSync } from 'fs';
 import { loadConfig, addHost, getHost } from '../utils/config.js';
+import { displayHostInfo, createHostChoices } from '../utils/display.js';
 import type { SSHHost } from '../types/ssh.js';
 
 export async function editCommand(hostName?: string) {
@@ -22,10 +23,7 @@ export async function editCommand(hostName?: string) {
                 name: 'selectedHost',
                 message: 'Select host to edit:',
                 choices: [
-                    ...config.hosts.map(host => ({
-                        name: `${chalk.cyan(host.name)} - ${host.user}@${host.host}:${host.port}`,
-                        value: host.name,
-                    })),
+                    ...createHostChoices(config.hosts),
                     new inquirer.Separator(),
                     {
                         name: chalk.gray('Cancel'),
@@ -173,15 +171,38 @@ export async function editCommand(hostName?: string) {
                     .filter(tag => tag.length > 0);
             },
         },
+        {
+            type: 'confirm',
+            name: 'hasAutoCommands',
+            message: 'Do you want to modify auto-run commands?',
+            default: !!(targetHost.autoCommands && targetHost.autoCommands.length > 0),
+        },
+        {
+            type: 'editor',
+            name: 'autoCommandsInput',
+            message: 'Enter commands to run automatically (one per line):',
+            default: targetHost.autoCommands ? targetHost.autoCommands.join('\n') : '',
+            when: answers => answers.hasAutoCommands,
+        },
     ]);
 
+    // Process auto commands
+    let autoCommands: string[] | undefined = undefined;
+    if (answers.hasAutoCommands && answers.autoCommandsInput) {
+        autoCommands = answers.autoCommandsInput
+            .split('\n')
+            .map((cmd: string) => cmd.trim())
+            .filter((cmd: string) => cmd.length > 0);
+    }
+
     const updatedHost: SSHHost = {
         name: answers.name,
         host: answers.host,
         user: answers.user,
         port: answers.port,
         keyPath: answers.authMethod === 'key' ? answers.keyPath : undefined,
         usePassword: answers.authMethod === 'password',
+        autoCommands: autoCommands,
         description: answers.description,
         tags: answers.tags,
     };
@@ -190,21 +211,7 @@ export async function editCommand(hostName?: string) {
         await addHost(updatedHost);
 
         console.log(chalk.green('✅ Host updated successfully!'));
-        console.log();
-        console.log(chalk.blue('📋 Updated host information:'));
-        console.log(`   ${chalk.cyan('Name:')} ${updatedHost.name}`);
-        console.log(`   ${chalk.cyan('Address:')} ${updatedHost.user}@${updatedHost.host}:${updatedHost.port}`);
-        if (updatedHost.keyPath) {
-            console.log(`   ${chalk.cyan('Key file:')} ${updatedHost.keyPath}`);
-        }
-        if (updatedHost.description) {
-            console.log(`   ${chalk.cyan('Description:')} ${updatedHost.description}`);
-        }
-        if (updatedHost.tags && updatedHost.tags.length > 0) {
-            console.log(`   ${chalk.cyan('Tags:')} ${updatedHost.tags.join(', ')}`);
-        }
-        console.log();
-        console.log(chalk.blue('💡 To connect:'), chalk.gray(`simple-ssh connect ${updatedHost.name}`));
+        displayHostInfo(updatedHost, 'Updated host information');
     } catch (error) {
         console.log(chalk.red('❌ Error updating host:'), error);
     }
diff --git a/packages/cli/src/commands/list.ts b/packages/cli/src/commands/list.ts
@@ -28,6 +28,9 @@ export async function listCommand() {
         } else {
             console.log(`   ${chalk.dim('🔧 Auth:')} ${chalk.gray('Default SSH settings')}`);
         }
+        if (host.autoCommands && host.autoCommands.length > 0) {
+            console.log(`   ${chalk.dim('🤖 Auto commands:')} ${chalk.magenta(`${host.autoCommands.length} command(s)`)}`);
+        }
     });
 
     console.log();
diff --git a/packages/cli/src/commands/remove.ts b/packages/cli/src/commands/remove.ts
@@ -1,6 +1,7 @@
 import inquirer from 'inquirer';
 import chalk from 'chalk';
 import { loadConfig, removeHost, getHost } from '../utils/config.js';
+import { createHostChoices } from '../utils/display.js';
 
 export async function removeCommand(hostName?: string) {
     const config = await loadConfig();
@@ -20,10 +21,7 @@ export async function removeCommand(hostName?: string) {
                 name: 'selectedHost',
                 message: 'Select host to remove:',
                 choices: [
-                    ...config.hosts.map(host => ({
-                        name: `${chalk.cyan(host.name)} - ${host.user}@${host.host}:${host.port}`,
-                        value: host.name,
-                    })),
+                    ...createHostChoices(config.hosts),
                     new inquirer.Separator(),
                     {
                         name: chalk.gray('Cancel'),
@@ -66,25 +64,25 @@ export async function removeCommand(hostName?: string) {
         {
             type: 'confirm',
             name: 'confirmed',
-            message: '정말로 삭제하시겠습니까?',
+            message: 'Are you sure you want to delete this host?',
             default: false,
         },
     ]);
 
     if (!confirmed) {
-        console.log(chalk.blue('취소되었습니다.'));
+        console.log(chalk.blue('Cancelled.'));
         return;
     }
 
     try {
         const success = await removeHost(targetHostName);
 
         if (success) {
-            console.log(chalk.green(`✅ 호스트 '${targetHostName}'이 성공적으로 삭제되었습니다.`));
+            console.log(chalk.green(`✅ Host '${targetHostName}' has been successfully removed.`));
         } else {
-            console.log(chalk.red(`❌ 호스트 '${targetHostName}' 삭제에 실패했습니다.`));
+            console.log(chalk.red(`❌ Failed to remove host '${targetHostName}'.`));
         }
     } catch (error) {
-        console.log(chalk.red('❌ 호스트 삭제 중 오류가 발생했습니다:'), error);
+        console.log(chalk.red('❌ Error occurred while removing host:'), error);
     }
 }
diff --git a/packages/cli/src/types/ssh.ts b/packages/cli/src/types/ssh.ts
@@ -4,8 +4,8 @@ export interface SSHHost {
     user: string;
     port: number;
     keyPath?: string;
-    usePassword?: boolean; // 비밀번호 사용 여부 (연결 시 입력받음)
-    autoCommands?: string[]; // 접속 후 자동 실행할 명령어들
+    usePassword?: boolean; // Whether to use password (prompted on connection)
+    autoCommands?: string[]; // Commands to run automatically after connection
     description?: string;
     tags?: string[];
 }
diff --git a/packages/cli/src/utils/config.ts b/packages/cli/src/utils/config.ts
@@ -4,7 +4,7 @@ import { join } from 'path';
 import { homedir } from 'os';
 import type { SSHConfig, SSHHost } from '../types/ssh.js';
 
-// 테스트 환경에서 HOME 환경변수를 우선 사용
+// Use HOME environment variable first for test environments
 function getHomeDir(): string {
     return process.env.HOME || process.env.USERPROFILE || homedir();
 }
@@ -43,14 +43,14 @@ export async function loadConfig(): Promise<SSHConfig> {
         const content = await readFile(configFile, 'utf-8');
         const config = JSON.parse(content) as SSHConfig;
 
-        // 기본값 병합
+        // Merge default values
         return {
             ...DEFAULT_CONFIG,
             ...config,
             hosts: config.hosts || [],
         };
     } catch (error) {
-        console.error('설정 파일을 읽는 중 오류가 발생했습니다:', error);
+        console.error('Error reading configuration file:', error);
         return DEFAULT_CONFIG;
     }
 }
@@ -61,15 +61,15 @@ export async function saveConfig(config: SSHConfig): Promise<void> {
     try {
         await writeFile(getConfigFile(), JSON.stringify(config, null, 2), 'utf-8');
     } catch (error) {
-        console.error('설정 파일을 저장하는 중 오류가 발생했습니다:', error);
+        console.error('Error saving configuration file:', error);
         throw error;
     }
 }
 
 export async function addHost(host: SSHHost): Promise<void> {
     const config = await loadConfig();
 
-    // 중복 이름 체크
+    // Check for duplicate names
     const existingIndex = config.hosts.findIndex(h => h.name === host.name);
     if (existingIndex >= 0) {
         config.hosts[existingIndex] = host;
diff --git a/packages/cli/src/utils/display.ts b/packages/cli/src/utils/display.ts
@@ -0,0 +1,44 @@
+import chalk from 'chalk';
+import type { SSHHost } from '../types/ssh.js';
+
+/**
+ * Display host information in a formatted way
+ */
+export function displayHostInfo(host: SSHHost, title = 'Host information'): void {
+    console.log();
+    console.log(chalk.blue(`📋 ${title}:`));
+    console.log(`   ${chalk.cyan('Name:')} ${host.name}`);
+    console.log(`   ${chalk.cyan('Address:')} ${host.user}@${host.host}:${host.port}`);
+
+    if (host.keyPath) {
+        console.log(`   ${chalk.cyan('Key file:')} ${host.keyPath}`);
+    }
+
+    if (host.description) {
+        console.log(`   ${chalk.cyan('Description:')} ${host.description}`);
+    }
+
+    if (host.tags && host.tags.length > 0) {
+        console.log(`   ${chalk.cyan('Tags:')} ${host.tags.join(', ')}`);
+    }
+
+    if (host.autoCommands && host.autoCommands.length > 0) {
+        console.log(`   ${chalk.cyan('Auto commands:')} ${host.autoCommands.length} command(s)`);
+        host.autoCommands.forEach((cmd, index) => {
+            console.log(`     ${chalk.dim(`${index + 1}.`)} ${chalk.yellow(cmd)}`);
+        });
+    }
+
+    console.log();
+    console.log(chalk.blue('💡 To connect:'), chalk.gray(`simple-ssh connect ${host.name}`));
+}
+
+/**
+ * Create host selection choices for inquirer
+ */
+export function createHostChoices(hosts: SSHHost[]) {
+    return hosts.map(host => ({
+        name: `${chalk.cyan(host.name)} - ${host.user}@${host.host}:${host.port}${host.description ? ` (${host.description})` : ''}`,
+        value: host.name,
+    }));
+}
diff --git a/packages/cli/tests/unit/config.test.ts b/packages/cli/tests/unit/config.test.ts

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,9 @@ export async function listCommand() {`
`28`	`28`	`} else {`
`29`	`29`	console.log(` ${chalk.dim('🔧 Auth:')} ${chalk.gray('Default SSH settings')}`);
`30`	`30`	`}`
	`31`	`+ if (host.autoCommands && host.autoCommands.length > 0) {`
	`32`	+ console.log(` ${chalk.dim('🤖 Auto commands:')} ${chalk.magenta(`${host.autoCommands.length} command(s)`)}`);
	`33`	`+ }`
`31`	`34`	`});`
`32`	`35`
`33`	`36`	`console.log();`