Skip to content

Commit 5e142fa

Browse files
authored
Merge pull request #21 from dwursteisen/main
Fix publication in maven local trying to sign artifact.
2 parents 518e779 + 5c826d2 commit 5e142fa

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

developer-plugin/src/main/kotlin/com/github/minigdx/gradle/plugin/MiniGdxDeveloperPlugin.kt

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,9 @@ import org.gradle.api.Plugin
1414
import org.gradle.api.Project
1515
import org.gradle.api.publish.PublishingExtension
1616
import org.gradle.api.publish.maven.MavenPublication
17-
import org.gradle.api.publish.maven.tasks.PublishToMavenRepository
18-
import org.gradle.jvm.tasks.Jar
17+
import org.gradle.plugins.signing.Sign
1918
import org.gradle.plugins.signing.SigningExtension
2019
import org.gradle.util.GradleVersion
21-
import org.jetbrains.dokka.gradle.DokkaTask
2220
import org.jetbrains.kotlin.gradle.plugin.extraProperties
2321
import java.io.File
2422

@@ -228,6 +226,10 @@ class MiniGdxDeveloperPlugin : Plugin<Project> {
228226
project.tasks.named(RELEASE_TASK_NAME).configure {
229227
it.onlyIf { project.layout.buildDirectory.dir("maven-central-portal").get().asFile.exists() }
230228
}
229+
230+
project.tasks.withType(Sign::class.java) {
231+
it.onlyIf { project.properties["signing.base64.secretKey"] != null }
232+
}
231233
}
232234
}
233235

developer-plugin/src/main/resources/github/workflows/publish-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,4 @@ jobs:
2525
java-version: 17
2626

2727
- name: Publish artifact
28-
run: ./gradlew publishAllPublicationsToMavenCentralRepository -Pversion="${{github.event.release.tag_name}}" -Psigning.base64.secretKey="${{secrets.SIGNING_BASE_64_SECRET_KEY}}" -Psigning.password="${{secrets.SIGNING_PASSWORD}}" -PsonatypeUsername="${{secrets.SONATYPE_USERNAME}}" -PsonatypePassword="${{secrets.SONATYPE_PASSWORD}}"
28+
run: ./gradlew publishAllPublicationToProjectLocalRepository zipMavenCentralPortalPublication releaseMavenCentralPortalPublication -Pversion="${{github.event.release.tag_name}}" -Psigning.base64.secretKey="${{secrets.SIGNING_BASE_64_SECRET_KEY}}" -Psigning.password="${{secrets.SIGNING_PASSWORD}}" -PcentralUsername="${{secrets.SONATYPE_USERNAME}}" -PcentralPassword="${{secrets.SONATYPE_PASSWORD}}"

0 commit comments

Comments
 (0)