Remove NodeCommon codegen (#328)

When used as embedded field it will make types appear to support serializer, when it doesn't.

No functional change.

Author: klauspost

health.go

@@ -47,6 +47,27 @@ import (
 	"github.com/shirou/gopsutil/v3/process"
 )
 
+// NodeCommon - Common fields across most node-specific health structs
+type NodeCommon struct {
+	Addr  string `json:"addr"`
+	Error string `json:"error,omitempty"`
+}
+
+// GetAddr - return the address of the node
+func (n *NodeCommon) GetAddr() string {
+	return n.Addr
+}
+
+// SetAddr - set the address of the node
+func (n *NodeCommon) SetAddr(addr string) {
+	n.Addr = addr
+}
+
+// SetError - set the address of the node
+func (n *NodeCommon) SetError(err string) {
+	n.Error = err
+}
+
 const (
 	// HealthInfoVersion0 is version 0
 	HealthInfoVersion0 = ""

metrics.go

@@ -622,6 +622,15 @@ func (n *NetMetrics) Merge(other *NetMetrics) {
 	n.NetStats.TxCompressed += other.NetStats.TxCompressed
 }
 
+//msgp:replace NodeCommon with:nodeCommon
+
+// nodeCommon - use as replacement for NodeCommon
+// We do not want to give NodeCommon codegen, since it is used for embedding.
+type nodeCommon struct {
+	Addr  string `json:"addr"`
+	Error string `json:"error,omitempty"`
+}
+
 // MemInfo contains system's RAM and swap information.
 type MemInfo struct {
 	NodeCommon