replaces deprecated v3 of artifact actions with v4 (#1260)

* replaces deprecated v3 of artifact actions with v4

* removes artifact re-upload if already uploaded

* Removes the commented out upload command

* removes artifacts to resolve Windows upload-artifact@v4 issue

* a new fix to resolve Windows upload-artifact@v4 issue

* replaces the misplaced fix

* fixes v3 to v4 issue

* fixes syntax issue

* removes sudo

* Another attempt to fix v3 to v4 migration

* recovers the code removed by mistake

---------

Co-authored-by: Ersan Bozduman <[email protected]>

Author: ebozduman

.github/workflows/minio-dotnet.yml

@@ -63,7 +63,7 @@ jobs:
 
       # Upload the normal artifacts
       - name: Upload the build output
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: build-artifacts
           path: |
@@ -72,13 +72,15 @@ jobs:
             **/*.csproj
             **/*.key
             **/*.crt
+          overwrite: true
 
       # Upload the Nuget packages
       - name: Upload the Nuget packages output
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: nuget-packages
           path: ./artifacts/*
+          overwrite: true
 
   format-check:
     runs-on: ubuntu-latest
@@ -123,7 +125,7 @@ jobs:
 
       # Download the build artifacts
       - name: Download the build artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: build-artifacts
           path: .
@@ -150,7 +152,7 @@ jobs:
 
       # Download the build artifacts
       - name: Download the build artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: build-artifacts
           path: .
@@ -191,7 +193,7 @@ jobs:
     steps:
       # Download the Nuget artifacts
       - name: Download the Nuget artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: nuget-packages
           path: ./artifacts