-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine all schedulers for all organisations #3838
Labels
Comments
jpbruinsslot
moved this from Incoming features / Need assessment
to To be discussed
in KAT
Nov 13, 2024
9 tasks
jpbruinsslot
changed the title
One scheduler type for all organisations
Combine all schedulers for all organisations
Nov 21, 2024
This was referenced Dec 12, 2024
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Proposal
The current situation is that we create individual 'schedulers' for every organisation, this amounts to 3 schedulers for every organisation.
The addition of queues in the scheduler being persisted as a database table allows us to explore the possibility of running a dedicated schedulers for all organisations.
Create one
BoefjeScheduler
,NormalizerScheduler
andReportScheduler
for all organisations instead of individual schedulers for every organisation. One message queue for all scan profile mutations to which scan profile mutations are posted of all organisations for theBoefjeScheduler
, and one message queue for raw file creation of all organisations for theNormalizerScheduler
, theReportScheduler
will reference its internal database table.Advantages
Disadvantages
allow_update
s,allow_replace
,allow_priority_updates
for individual organisations can't be used, however this function doesn't seem to be used and is for every type scheduler the sameImpact
Next steps and impact
/queues
to/schedulers/{id}/pop
, additionally it will return a paginated result instead of a singleTask
, this is because the pop endpoint now supports filtering with multiple tasks returns. Services that rely on the scheduler pop endpoint need to update their interfaces (Update services that rely on/pop
endpoint of scheduler #3961)/queues
toschedulers/{id}/push
, services that interface with the push endpoints (rocky) need to update their interfaces. (Update services that rely on/push
endpoint of scheduler #3962)organisation
fields are added toTask
,Schedule
, services using these models need to update their specifications. (Model definition updates: addition oforganisation
field toTask
andSchedule
models #3965)PR
#3839
The text was updated successfully, but these errors were encountered: