Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let local plugins (files) take precedence over database entries #3858

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Donnype
Copy link
Contributor

@Donnype Donnype commented Nov 19, 2024

Changes

This makes sure we return info from the boefjes.json and schema.json instead of returning data in the database. This solves issues where we updated these files locally but did not see the changes reflected due to a stale database.

Issue link

Closes #3850

Demo

QA notes

Please enable dns-records and then delete the schema.json file in the kat_dns directory in the boefjes module. In the KATalogus, we should see no more settings for dns-records (perhaps after a restart of the boefjes container: docker compose restart boefje katalogus).


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@Donnype Donnype requested a review from a team as a code owner November 19, 2024 20:50
Copy link

sonarcloud bot commented Nov 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
40.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static boefjes in the database get a static schema as well
1 participant