Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support using Manon inside page-wide wrapping element #407

Open
ppvg opened this issue Nov 6, 2023 · 0 comments
Open

Support using Manon inside page-wide wrapping element #407

ppvg opened this issue Nov 6, 2023 · 0 comments
Labels
feature request New feature or request Layout Component 'Layout'
Milestone
Fase 2 Manon

Comments

@ppvg
Copy link
Member

ppvg commented Nov 6, 2023

Currently Manon explicitly targets some elements as direct descendants of body, for example body > main and body > header nav.collapsible. This makes it impossible to use Manon correctly in contexts where a page-wide wrapping element is required, for example when using a frontend framework that might otherwise interfere with elements that are appended to the body by browser extensions.

For some components, an undocumented alternative way to target it is supported, such as the .page-header and .page-footer classes.

It would be nice if this could be supported (and documented) for all cases. Or perhaps a simpler approach could be adopted (if possible): adding a .manon-root class that can act as a stand-in for body in these cases:

<body>
  <div class="manon-root" style="display: contents">
    <!-- Content rendered by frontend framework: -->
    <header>
      <!-- [...] -->
    </header>
  </div>
</body>
@HeleenSG HeleenSG added the feature request New feature or request label Sep 19, 2024
@reinschaap reinschaap added the Layout Component 'Layout' label Sep 26, 2024
@Davidemeer Davidemeer added this to the Fase 2 Manon milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request Layout Component 'Layout'
Projects
None yet
Milestone
Fase 2 Manon
Development

No branches or pull requests
4 participants
@ppvg @HeleenSG @Davidemeer @reinschaap