fix: 修复useActive 中 items 为空数组导致的异常 (ant-design#824)

Co-authored-by: LengYXin <[email protected]>

Author: 2 people

components/suggestion/__tests__/useActive.test.tsx

@@ -0,0 +1,60 @@
+import { renderHook } from '@testing-library/react';
+import React from 'react';
+import type { SuggestionItem } from '../index';
+import useActive from '../useActive';
+
+describe('useActive', () => {
+  it('should initialize activePaths with first item value when open is true and items is valid array', () => {
+    const items: SuggestionItem[] = [
+      { label: 'Item 1', value: 'item1' },
+      { label: 'Item 2', value: 'item2' },
+    ];
+
+    const { result } = renderHook(() => useActive(items, true, false, jest.fn(), jest.fn()));
+
+    const [activePaths] = result.current;
+    expect(activePaths).toEqual(['item1']);
+  });
+
+  it('should not initialize activePaths when open is false', () => {
+    const items: SuggestionItem[] = [{ label: 'Item 1', value: 'item1' }];
+
+    const { result } = renderHook(() => useActive(items, false, false, jest.fn(), jest.fn()));
+
+    const [activePaths] = result.current;
+    expect(activePaths).toEqual([]);
+  });
+
+  it('should not initialize activePaths when items is empty array', () => {
+    const { result } = renderHook(() => useActive([], true, false, jest.fn(), jest.fn()));
+
+    const [activePaths] = result.current;
+    expect(activePaths).toEqual([]);
+  });
+
+  it('should not initialize activePaths when items is not a valid array', () => {
+    // Test with null
+    const { result: result1 } = renderHook(() =>
+      useActive(null as any, true, false, jest.fn(), jest.fn()),
+    );
+
+    const [activePaths1] = result1.current;
+    expect(activePaths1).toEqual([]);
+
+    // Test with undefined
+    const { result: result2 } = renderHook(() =>
+      useActive(undefined as any, true, false, jest.fn(), jest.fn()),
+    );
+
+    const [activePaths2] = result2.current;
+    expect(activePaths2).toEqual([]);
+
+    // Test with non-array value
+    const { result: result3 } = renderHook(() =>
+      useActive('not-an-array' as any, true, false, jest.fn(), jest.fn()),
+    );
+
+    const [activePaths3] = result3.current;
+    expect(activePaths3).toEqual([]);
+  });
+});

components/suggestion/useActive.ts

@@ -1,6 +1,6 @@
 import { useEvent } from 'rc-util';
-import type { SuggestionItem } from '.';
 import React from 'react';
+import type { SuggestionItem } from '.';
 
 /**
  * Since Cascader not support ref active, we use `value` to mock the active item.
@@ -117,7 +117,8 @@ export default function useActive(
   });
 
   React.useEffect(() => {
-    if (open) {
+    // 确保 items 是一个数组且至少有一个元素
+    if (open && Array.isArray(items) && items.length > 0) {
       setActivePaths([items[0].value]);
     }
   }, [open]);