tests: query for nested interface #56
Open
+54
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BarryThePenguin, thanks for opening this PR! Is the intention to add a failing test or is it to fully fix the issue you reported? Thanks! |
|
It was a failing test originally, just the schema changes alone were enough to reproduce the issue. I ended up fixing my original issue by using I'll have a go at separating the two commits 👀 |
|
Cool. Don't feel you have to separate the commits into separate PRs, if that's what you meant. Feel free to update the PR title and description to match the changes and mention that it fixes your issue # and all should be good. Thanks! |
BarryThePenguin
force-pushed
the
tests/nested-interface
branch
from
8cdd9fe
to
d82f525
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a field and query to the tests that reproduces the issue I've been facing
I fixed my original issue by adding a
isListargument toresolveInterface(), similar toresolveUnion(). This allowsresolveInterface()to resolve a field that is a list withresolveList().Fixes #55