diff --git a/includes/FormFactory/ManageWikiFormFactoryBuilder.php b/includes/FormFactory/ManageWikiFormFactoryBuilder.php index fc0c49aba..c35359f25 100644 --- a/includes/FormFactory/ManageWikiFormFactoryBuilder.php +++ b/includes/FormFactory/ManageWikiFormFactoryBuilder.php @@ -836,10 +836,10 @@ public static function submissionHandler( throw new InvalidArgumentException( "{$module} not recognised" ); } - if ( $mwReturn->changes ) { + if ( $mwReturn->hasChanges() ) { $mwReturn->commit(); - if ( $module != 'permissions' ) { + if ( $module !== 'permissions' ) { $mwReturn->logParams['4::wiki'] = $dbName; } @@ -854,7 +854,7 @@ public static function submissionHandler( return [ [ 'managewiki-changes-none' => null ] ]; } - if ( $mwReturn->errors ?? [] && $module == 'permissions' ) { + if ( $mwReturn->errors ?? [] && $module === 'permissions' ) { return $mwReturn->errors; }