Generator: Incorrect File Extension in Imports for Generated Client

[maaaathis]

Problem Description

The generated client currently includes .js file extensions in the imports of local files like the descriptors.js and types.js. This causes issues with frameworks like Next.js, which do not handle these imports correctly. As a result, users are forced to manually remove the .js extension from these imports.

Steps to Reproduce

1. Generate the client using the provided tool.
2. Notice that the imports of local files in the generated code include .js extensions.
3. Attempt to use the generated client in a Next.js project.
4. Observe the errors related to import paths with .js extensions.

Example

Here is an example of the problematic import statement:

import * as descriptors from "./descriptors.js";

This needs to be manually corrected to:

import * as descriptors from "./descriptors";

Proposed Solution

Update the client generation logic to omit the .js file extension in the imports of local files. This change should ensure compatibility with frameworks like Next.js and improve the overall usability of the generated client.

[martin-helmich]

I'm confused tbh., since I've never had any issues with this. Is this maybe some kind of ESM vs. CJS thing?

[maaaathis]

I'm confused tbh., since I've never had any issues with this. Is this maybe some kind of ESM vs. CJS thing?

Yes, exactly. The .js endings in internal imports are usually required for ESM-based projects. But if you change the TypeScript moduleResolution to bundler (which Next.js does out-of-the-box) this is no longer required and even breaks the generated files.