Skip to content

Commit 9278c2f

Browse files
authored
Merge pull request #211 from tariq1890/no-pkg-errors
remove pkg/errors import in favour of stdlib errors
2 parents ee0d3c4 + 67a43ec commit 9278c2f

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ module github.com/mittwald/go-helm-client
33
go 1.22.0
44

55
require (
6-
github.com/pkg/errors v0.9.1
76
github.com/spf13/pflag v1.0.5
87
go.uber.org/mock v0.4.0
98
helm.sh/helm/v3 v3.15.2
@@ -96,6 +95,7 @@ require (
9695
github.com/opencontainers/go-digest v1.0.0 // indirect
9796
github.com/opencontainers/image-spec v1.1.0-rc6 // indirect
9897
github.com/peterbourgon/diskv v2.0.1+incompatible // indirect
98+
github.com/pkg/errors v0.9.1 // indirect
9999
github.com/prometheus/client_golang v1.18.0 // indirect
100100
github.com/prometheus/client_model v0.5.0 // indirect
101101
github.com/prometheus/common v0.45.0 // indirect

spec.go

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
package helmclient
22

33
import (
4-
"github.com/pkg/errors"
4+
"fmt"
5+
56
"helm.sh/helm/v3/pkg/getter"
67
"sigs.k8s.io/yaml"
78

@@ -15,12 +16,12 @@ func (spec *ChartSpec) GetValuesMap(p getter.Providers) (map[string]interface{},
1516

1617
err := yaml.Unmarshal([]byte(spec.ValuesYaml), &valuesYaml)
1718
if err != nil {
18-
return nil, errors.Wrap(err, "Failed to Parse ValuesYaml")
19+
return nil, fmt.Errorf("failed to parse ValuesYaml: %w", err)
1920
}
2021

2122
valuesOptions, err := spec.ValuesOptions.MergeValues(p)
2223
if err != nil {
23-
return nil, errors.Wrap(err, "Failed to Parse ValuesOptions")
24+
return nil, fmt.Errorf("failed to parse ValuesOptions: %w", err)
2425
}
2526

2627
return values.MergeMaps(valuesYaml, valuesOptions), nil

values/options.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@ Changes:
2323
package values
2424

2525
import (
26+
"fmt"
2627
"io"
2728
"net/url"
2829
"os"
2930
"strings"
3031

31-
"github.com/pkg/errors"
3232
"sigs.k8s.io/yaml"
3333

3434
"helm.sh/helm/v3/pkg/getter"
@@ -65,7 +65,7 @@ func (opts *Options) MergeValues(p getter.Providers) (map[string]interface{}, er
6565
}
6666

6767
if err := yaml.Unmarshal(bytes, &currentMap); err != nil {
68-
return nil, errors.Wrapf(err, "failed to parse %s", filePath)
68+
return nil, fmt.Errorf("failed to parse %s: %w", filePath, err)
6969
}
7070
// Merge with the previous map
7171
base = MergeMaps(base, currentMap)
@@ -74,21 +74,21 @@ func (opts *Options) MergeValues(p getter.Providers) (map[string]interface{}, er
7474
// User specified a value via --set-json
7575
for _, value := range opts.JSONValues {
7676
if err := strvals.ParseJSON(value, base); err != nil {
77-
return nil, errors.Errorf("failed parsing --set-json data %s", value)
77+
return nil, fmt.Errorf("failed parsing --set-json data %s: %w", value, err)
7878
}
7979
}
8080

8181
// User specified a value via --set
8282
for _, value := range opts.Values {
8383
if err := strvals.ParseInto(value, base); err != nil {
84-
return nil, errors.Wrap(err, "failed parsing --set data")
84+
return nil, fmt.Errorf("failed parsing --set data: %w", err)
8585
}
8686
}
8787

8888
// User specified a value via --set-string
8989
for _, value := range opts.StringValues {
9090
if err := strvals.ParseIntoString(value, base); err != nil {
91-
return nil, errors.Wrap(err, "failed parsing --set-string data")
91+
return nil, fmt.Errorf("failed parsing --set-string data: %w", err)
9292
}
9393
}
9494

@@ -102,7 +102,7 @@ func (opts *Options) MergeValues(p getter.Providers) (map[string]interface{}, er
102102
return string(bytes), err
103103
}
104104
if err := strvals.ParseIntoFile(value, base, reader); err != nil {
105-
return nil, errors.Wrap(err, "failed parsing --set-file data")
105+
return nil, fmt.Errorf("failed parsing --set-file data: %w", err)
106106
}
107107
}
108108

0 commit comments

Comments
 (0)