Running TemplateChart breaks GetRelease

[ConnorsApps]

The Issue

Running Client.TemplateChart breaks Client.GetRelease.

1. GetRelease("my-release") Works ✅
2. TemplateChart(....) Works ✅
3. GetRelease("my-release") Fails 🛑 release: not found

Cause of problem

The issue is from this line in the upstream helm repo. helm/pkg/action/install.go#L269

mem := driver.NewMemory()
mem.SetNamespace(i.Namespace)
i.cfg.Releases = storage.Init(mem)

Possible Workaround

mittwald/go-helm-client/client.go#L466

import helmStorage "helm.sh/helm/v3/pkg/storage"

func (c *HelmClient) TemplateChart(....) ([]byte, error) {
// Copy as is
ogReleases := c.ActionConfig.Releases
// Set temporary empty new storage
c.ActionConfig.Releases = helmStorage.Init(ogReleases.Driver)
defer func() {
	// Set back to value it was to start with
	c.ActionConfig.Releases = ogReleases
}()

Test to reproduce issue

package helmclient

import (
	"fmt"
	"os"
	"path/filepath"
	"testing"

	"helm.sh/helm/v3/pkg/chartutil"
	"helm.sh/helm/v3/pkg/repo"
	"k8s.io/client-go/discovery"
	"k8s.io/client-go/rest"
	"k8s.io/client-go/tools/clientcmd"
)

func must(err error) {
	if err != nil {
		panic(err)
	}
}

func mustGetClusterKubeVersion(restConfig *rest.Config) *chartutil.KubeVersion {
	discoveryClient, err := discovery.NewDiscoveryClientForConfig(restConfig)
	must(err)
	information, err := discoveryClient.ServerVersion()
	must(err)
	kubeVersion, err := chartutil.ParseKubeVersion(information.GitVersion)
	must(err)
	return kubeVersion
}

func mustMakeHelmClient(kubeConfigPath, kubeContextName, namespace string) (*rest.Config, Client) {
	restConfig, err := clientcmd.NewNonInteractiveDeferredLoadingClientConfig(
		&clientcmd.ClientConfigLoadingRules{ExplicitPath: kubeConfigPath},
		&clientcmd.ConfigOverrides{CurrentContext: kubeContextName},
	).ClientConfig()
	must(err)
	client, err := NewClientFromRestConf(&RestConfClientOptions{
		RestConfig: restConfig,
		Options: &Options{
			Namespace: namespace,
		},
	})
	must(err)
	return restConfig, client
}

func TestTemplateThenGetRelease(_ *testing.T) {
	var (
		kubeContextName = "some-context-name"
		myReleaseName   = "my-release"
		namespace       = "my-namespace"
		kubeConfigPath  = filepath.Join(os.Getenv("HOME"), ".kube", "config")
	)

	restConfig, client := mustMakeHelmClient(kubeConfigPath, kubeContextName, namespace)

	release, err := client.GetRelease(myReleaseName)
	must(err)
	fmt.Println("Successfully got release: check 1", release.Name)

	err = client.AddOrUpdateChartRepo(repo.Entry{
		Name: "nginx-stable",
		URL:  "https://helm.nginx.com/stable",
	})
	must(err)

	_, err = client.TemplateChart(&ChartSpec{
		Namespace:   namespace,
		ChartName:   "nginx-stable/nginx-ingress",
		ReleaseName: "nginx-ingress",
	}, &HelmTemplateOptions{KubeVersion: mustGetClusterKubeVersion(restConfig)})
	must(err)

	fmt.Println("Templated chart")

	release, err = client.GetRelease(myReleaseName) // Failing here  🛑 
	must(err)

	fmt.Println("Successfully got release: check 2", release.Name)
}

Before I make a pull request, anyone have any thoughts?