Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade: Dependency Update is not implemented at all #79

Open
Illya123 opened this issue Apr 26, 2022 · 0 comments
Open

Upgrade: Dependency Update is not implemented at all #79

Illya123 opened this issue Apr 26, 2022 · 0 comments

Comments

@Illya123
Copy link

On upgrade upgradeOptions.DependencyUpdate is not set from the chartSpec and no dependencyupdate is implemented for upgrade.

My troubleshooting in client.go:

  • In the func 'upgrade(ctx context.Context, spec *ChartSpec)': there is only a check validating that all dependencies are there, but the flag upgradeOptions.DependencyUpdate is never set or read.

I see no harm in adding the dependencyUpdate in upgrade analogous to the install command.

Relates to #78
@Illya123 Illya123 mentioned this issue Apr 26, 2022
Open
guitarlum pushed a commit to guitarlum/go-helm-client that referenced this issue Apr 26, 2022
Issues mittwald#78 mittwald#79 mittwald#80 addressed and fixed
edde7e5
elenz97 added a commit that referenced this issue Apr 27, 2022
@elenz97
Merge pull request #81 from guitarlum/master
1d53dff 
Fix for #78 #79 and #80 with some refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Illya123