Allow Customization of ssh-privatekey and ssh-publickey for SSHKeyPair

[jkupferer]

Is your feature request related to a problem? Please describe.

For compatibility with using deploy keys with ArgoCD it is necessary to be able to generate SSH keypair secrets with data sshPrivateKey rather than the default ssh-privatekey.

Other use cases may also require the SSH public and private keys to use custom data names.

Describe the solution you'd like

Perhaps add spec.sshPrivateKeyDataName and spec.sshPublicKeyDataName to SSHKeyPair custom resource to allow overriding the defaults?

Describe alternatives you've considered

I've been unable to come up with a reasonable alternative.

Additional context

n/a

[jkupferer]

#91 addresses similar needs. Perhaps this feature request should be folded into that one?

[martin-helmich]

Perhaps add spec.sshPrivateKeyDataName and spec.sshPublicKeyDataName to SSHKeyPair custom resource to allow overriding the defaults?

That sounds reasonable! Currently, our capacities to work on this project are limited, so PRs are always welcome.

[mrchypark]

@jkupferer I am currently attempting to work on #91. I would like to address this issue together. Can we discuss the design aspect in #91?

[jkupferer]

@mrchypark Sorry for having missed your comment for so long. Is this something you are still looking at?

[mrchypark]

@jkupferer No. I was also busy with other things, so I couldn't keep up with it even though it was necessary. We can restart the conversation if needed.

[lee-baines]

We also really need this feature. Currently we are overriding the key names with some Helm trickery but name argument would be really useful