You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 21, 2020. It is now read-only.
The property naming with OAuth.ts for the OAuthProvider constructor's options.tokens is inconsistent with what the OAuth api returns equating to the program having to do some middle-man-mutating of the api's response before calling the OAuth constructor.
API Uses
OAuth.ts Uses
client_id
clientId
client_secret
secret
access_token
access
refresh_token
refresh
expires_in
expires*
*) This is fine as the two names refer to two different pieces of data (API returns a number, OAuth.ts expects a ISO date string)
This is predominately only an issue with the setTokens() function. Since its called from the constructor it inhibits the user/app from passing an oauth api response directly into the constructor.
The text was updated successfully, but these errors were encountered:
SReject
changed the title
Inconsistant Naming between oauth api and OAuth.ts
Inconsistent Naming between oauth api and OAuth.ts
Jul 22, 2018
The property naming with OAuth.ts for the OAuthProvider constructor's
options.tokens
is inconsistent with what the OAuth api returns equating to the program having to do some middle-man-mutating of the api's response before calling the OAuth constructor.*) This is fine as the two names refer to two different pieces of data (API returns a number, OAuth.ts expects a ISO date string)
This is predominately only an issue with the
setTokens()
function. Since its called from the constructor it inhibits the user/app from passing an oauth api response directly into the constructor.The text was updated successfully, but these errors were encountered: