Skip to content
This repository has been archived by the owner on Jul 31, 2020. It is now read-only.

setCooldown Overwrite with Shorter Cooldown #66

Open
kateract opened this issue Jun 8, 2017 · 0 comments
Open

setCooldown Overwrite with Shorter Cooldown #66

kateract opened this issue Jun 8, 2017 · 0 comments

Comments

@kateract
Copy link
Contributor

kateract commented Jun 8, 2017

Currently, when you call setCooldown on a button, it resets the cooldown to the new value, even if it's shorter. Would it be preferred to keep the existing cooldown if longer, and perhaps provide an optional boolean argument overwriiteCoolodwn to setCooldown to force replacement of the cooldown?

Depending on your point of view, this could be seen as either a breaking change, or as a bugfix where the intended behavior would be to keep the longer cooldown.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant