Small tweaks

Author: mjackson

packages/form-data-parser/src/lib/form-data.ts

@@ -70,18 +70,19 @@ export interface FileUploadHandler {
 }
 
 async function defaultFileUploadHandler(file: FileUpload): Promise<File> {
-  // Do the slow thing and buffer the entire file in memory.
+  // Buffer the file in memory
   let buffer = await file.arrayBuffer();
   return new File([buffer], file.name, { type: file.type, lastModified: file.lastModified });
 }
 
 /**
- * Parses a `Request` body into a `FormData` object. This is useful for accessing the data contained
- * in a HTTP `POST` request generated by a HTML `<form>` element.
+ * Parses a [`Request`](https://developer.mozilla.org/en-US/docs/Web/API/Request) body into a [`FormData`](https://developer.mozilla.org/en-US/docs/Web/API/FormData)
+ * object. This is useful when accessing the data contained in a HTTP `multipart/form-data` request
+ * generated by a HTML `<form>` element.
  *
- * The major difference between this function and using the built-in `request.formData()` API is the
- * ability to customize the handling of file uploads. Instead of buffering the entire file in memory,
- * the `uploadHandler` allows you to store the file on disk or in a cloud storage service.
+ * The main difference between this function and using [the built-in `request.formData()` API](https://developer.mozilla.org/en-US/docs/Web/API/Request/formData)
+ * is the ability to customize the handling of file uploads. Instead of buffering the entire file in
+ * memory, the `uploadHandler` allows you to stream the file to disk or a cloud storage service.
  */
 export async function parseFormData(
   request: Request,
@@ -96,14 +97,15 @@ export async function parseFormData(
   let promises: Promise<void | null | string | File>[] = [];
 
   for await (let part of parseMultipartRequest(request, parserOptions)) {
-    if (!part.name) continue;
+    let fieldName = part.name;
+
+    if (!fieldName) continue;
 
     if (part.isFile) {
       let value = uploadHandler(new FileUpload(part));
 
       if (value != null) {
         if (isPromise(value)) {
-          let fieldName = part.name;
           promises.push(
             value.then((file) => {
               if (file != null) {
@@ -112,11 +114,11 @@ export async function parseFormData(
             }),
           );
         } else {
-          formData.append(part.name, value);
+          formData.append(fieldName, value);
         }
       }
     } else {
-      formData.append(part.name, await part.text());
+      formData.append(fieldName, await part.text());
     }
   }