Remove ctad polyfill for clang < 17

Author: mjacobse

ctldl/factor_data/sparsity_to_factorize_tridiagonal_arrowhead_linked.hpp

@@ -51,27 +51,4 @@ struct SparsityToFactorizeTridiagonalArrowheadLinked {
       outer;
 };
 
-// needed for clang < 17 which does not do the CTAD for aggregates otherwise
-template <std::size_t dim_start, std::size_t dim_tridiag, std::size_t dim_link,
-          std::size_t dim_outer, std::size_t nnz_start_diag,
-          std::size_t nnz_start_tridiag, std::size_t nnz_start_outer,
-          std::size_t nnz_tridiag_diag, std::size_t nnz_tridiag_subdiag,
-          std::size_t nnz_link_tridiag, std::size_t nnz_link_diag,
-          std::size_t nnz_link_outer, std::size_t nnz_outer_subdiagonal,
-          std::size_t nnz_outer_diagonal>
-SparsityToFactorizeTridiagonalArrowheadLinked(
-    SparsityToFactorizeStart<dim_start, dim_tridiag, dim_outer, nnz_start_diag,
-                             nnz_start_tridiag, nnz_start_outer>,
-    SparsityToFactorizeTridiagonal<dim_tridiag, nnz_tridiag_diag,
-                                   nnz_tridiag_subdiag>,
-    SparsityToFactorizeLink<dim_tridiag, dim_link, dim_outer, nnz_link_tridiag,
-                            nnz_link_diag, nnz_link_outer>,
-    SparsityToFactorizeOuter<dim_tridiag, dim_outer, nnz_outer_subdiagonal,
-                             nnz_outer_diagonal>)
-    -> SparsityToFactorizeTridiagonalArrowheadLinked<
-        dim_start, dim_tridiag, dim_link, dim_outer, nnz_start_diag,
-        nnz_start_tridiag, nnz_start_outer, nnz_tridiag_diag,
-        nnz_tridiag_subdiag, nnz_link_tridiag, nnz_link_diag, nnz_link_outer,
-        nnz_outer_subdiagonal, nnz_outer_diagonal>;
-
 }  // namespace ctldl

ctldl/matrix/matrix_link.hpp

@@ -13,10 +13,6 @@ struct MatrixLink {
   Next next;
 };
 
-// needed for clang < 17 which does not do the CTAD for aggregates otherwise
-template <class Prev, class Diag, class Outer>
-MatrixLink(Prev, Diag, Outer) -> MatrixLink<Prev, Diag, Outer>;
-
 template <std::size_t dim_prev, std::size_t dim_link, std::size_t dim_next>
 constexpr auto makeEmptyMatrixLink() {
   return MatrixLink{EmptyMatrixInput<dim_link, dim_prev>{},

ctldl/matrix/matrix_outer.hpp

@@ -13,10 +13,6 @@ struct MatrixOuter {
   Diag diag;
 };
 
-// needed for clang < 17 which does not do the CTAD for aggregates otherwise
-template <class Subdiag, class Diag>
-MatrixOuter(Subdiag, Diag) -> MatrixOuter<Subdiag, Diag>;
-
 template <std::size_t num_rows, std::size_t num_cols>
 constexpr auto makeEmptyMatrixRepeatingOuter(
     const std::size_t num_repetitions) {

ctldl/matrix/matrix_start.hpp

@@ -13,10 +13,6 @@ struct MatrixStart {
   Outer outer;
 };
 
-// needed for clang < 17 which does not do the CTAD for aggregates otherwise
-template <class Diag, class Next, class Outer>
-MatrixStart(Diag, Next, Outer) -> MatrixStart<Diag, Next, Outer>;
-
 template <std::size_t dim_start, std::size_t dim_next, std::size_t dim_outer>
 constexpr auto makeEmptyMatrixStart() {
   return MatrixStart{EmptyMatrixInput<dim_start, dim_start>{},

ctldl/matrix/matrix_tridiagonal.hpp

@@ -8,8 +8,4 @@ struct MatrixTridiagonal {
   Subdiag subdiag;
 };
 
-// needed for clang < 17 which does not do the CTAD for aggregates otherwise
-template <class Diag, class Subdiag>
-MatrixTridiagonal(Diag, Subdiag) -> MatrixTridiagonal<Diag, Subdiag>;
-
 }  // namespace ctldl

ctldl/matrix/matrix_tridiagonal_arrowhead_linked.hpp

@@ -10,9 +10,4 @@ struct MatrixTridiagonalArrowheadLinked {
   Outer outer;
 };
 
-// needed for clang < 17 which does not do the CTAD for aggregates otherwise
-template <class Start, class Tridiag, class Link, class Outer>
-MatrixTridiagonalArrowheadLinked(Start, Tridiag, Link, Outer)
-    -> MatrixTridiagonalArrowheadLinked<Start, Tridiag, Link, Outer>;
-
 }  // namespace ctldl

ctldl/symbolic/lower_triangle_blocked.hpp

@@ -18,11 +18,6 @@ struct LowerTriangleBlocked3x3 {
   Block33 block33;
 };
 
-// needed for clang < 17 which does not do the CTAD for aggregates otherwise
-template <class T11, class T21, class T22, class T31, class T32, class T33>
-LowerTriangleBlocked3x3(T11, T21, T22, T31, T32, T33)
-    -> LowerTriangleBlocked3x3<T11, T21, T22, T31, T32, T33>;
-
 template <class T11, class T21, class T22>
 struct LowerTriangleBlocked {
   using Block11 = T11;
@@ -33,8 +28,4 @@ struct LowerTriangleBlocked {
   Block22 block22;
 };
 
-// needed for clang < 17 which does not do the CTAD for aggregates otherwise
-template <class T11, class T21, class T22>
-LowerTriangleBlocked(T11, T21, T22) -> LowerTriangleBlocked<T11, T21, T22>;
-
 }  // namespace ctldl

ctldl/vector/vector_tridiagonal_arrowhead_linked.hpp

@@ -10,9 +10,4 @@ struct VectorTridiagonalArrowheadLinked {
   Outer outer;
 };
 
-// needed for clang < 17 which does not do the CTAD for aggregates otherwise
-template <class Start, class Tridiag, class Link, class Outer>
-VectorTridiagonalArrowheadLinked(Start, Tridiag, Link, Outer)
-    -> VectorTridiagonalArrowheadLinked<Start, Tridiag, Link, Outer>;
-
 }  // namespace ctldl