Skip to content

mj-social attribute bugs (align and icon-height) #3001

@dazgreer

Description

@dazgreer

Describe the bug

  1. For mj-social-element there is an attribute of align specified in the documentation however this is not set anywhere in the code when added and it doesn’t really make sense what it would do
  2. When using the attribute icon-height on the mj-social tag, the height attribute is set both on the icon container (the background color part) and the icon itself (icon image). For most email clients, the CSS prevents the height of the icon image from taking the set value and instead this is applied to the icon container only, however in Outlook and some instances of Yahoo the image becomes stretched outside of its aspect ratio.

To Reproduce
Steps to reproduce the behavior:

  1. https://mjml.io/try-it-live/dn69y69b8z
  2. https://mjml.io/try-it-live/bf8oF2BHq7

Expected behavior
Adding the text-align attribute should align the text when possible, for example when mode="vertical" is applied
Adding icon-height should only affect the container (background) and not the image itself

MJML environment (please complete the following information):

  1. https://mjml.io/try-it-live/dn69y69b8z
  2. https://mjml.io/try-it-live/bf8oF2BHq7

Email sending environment(for rendering issues):
Email on Acid / Testi

Affected email clients (for rendering issues):
All version of Outlook (Windows)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions