Skip to content

Warnings compiling scp.c and progressmeter.c #381

@prpr19xx

Description

@prpr19xx

Compiling with:
make PROGRAMS="dropbear dbclient dropbearkey dropbearconvert scp" MULTI=1 SCPPROGRESS=1
gives some warnings:

gcc -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fPIE -Wundef -fno-strict-overflow -Wno-pointer-sign -Os -W -Wall  -I./src/../libtomcrypt/src/headers/ -I. -I./src -DDROPBEAR_SERVER -DDROPBEAR_CLIENT -DPROGRESS_METER -DDBMULTI_dropbear -DDBMULTI_dbclient -DDBMULTI_dropbearkey -DDBMULTI_dropbearconvert -DDBMULTI_scp -DDROPBEAR_MULTI src/progressmeter.c -o obj/progressmeter.o -c
src/progressmeter.c: In function ‘update_progress_meter’:
src/progressmeter.c:220:27: warning: unused parameter ‘ignore’ [-Wunused-parameter]
  220 | update_progress_meter(int ignore)
      |                       ~~~~^~~~~~
src/progressmeter.c: In function ‘sig_winch’:
src/progressmeter.c:274:15: warning: unused parameter ‘sig’ [-Wunused-parameter]
  274 | sig_winch(int sig)
      |           ~~~~^~~
gcc -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fPIE -Wundef -fno-strict-overflow -Wno-pointer-sign -Os -W -Wall  -I./src/../libtomcrypt/src/headers/ -I. -I./src -DDROPBEAR_SERVER -DDROPBEAR_CLIENT -DPROGRESS_METER -DDBMULTI_dropbear -DDBMULTI_dbclient -DDBMULTI_dropbearkey -DDBMULTI_dropbearconvert -DDBMULTI_scp -DDROPBEAR_MULTI src/queue.c -o obj/queue.o -c
gcc -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fPIE -Wundef -fno-strict-overflow -Wno-pointer-sign -Os -W -Wall  -I./src/../libtomcrypt/src/headers/ -I. -I./src -DDROPBEAR_SERVER -DDROPBEAR_CLIENT -DPROGRESS_METER -DDBMULTI_dropbear -DDBMULTI_dbclient -DDBMULTI_dropbearkey -DDBMULTI_dropbearconvert -DDBMULTI_scp -DDROPBEAR_MULTI src/rsa.c -o obj/rsa.o -c
gcc -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fPIE -Wundef -fno-strict-overflow -Wno-pointer-sign -Os -W -Wall  -I./src/../libtomcrypt/src/headers/ -I. -I./src -DDROPBEAR_SERVER -DDROPBEAR_CLIENT -DPROGRESS_METER -DDBMULTI_dropbear -DDBMULTI_dbclient -DDBMULTI_dropbearkey -DDBMULTI_dropbearconvert -DDBMULTI_scp -DDROPBEAR_MULTI src/scp.c -o obj/scp.o -c
src/scp.c: In function ‘source’:
src/scp.c:685:44: warning: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘off_t’ {aka ‘long int’} [-Wsign-compare]
  685 |                                 if (result != amt)
      |                                            ^~
src/scp.c:692:44: warning: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘off_t’ {aka ‘long int’} [-Wsign-compare]
  692 |                                 if (result != amt)
      |                                            ^~
src/scp.c: In function ‘allocbuf’:
src/scp.c:1224:23: warning: unused parameter ‘fd’ [-Wunused-parameter]
 1224 | allocbuf(BUF *bp, int fd, int blksize)
      |                   ~~~~^~
src/scp.c: In function ‘do_cmd’:
src/scp.c:202:9: warning: ignoring return value of ‘pipe’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  202 |         pipe(reserved);
      |         ^~~~~~~~~~~~~~
src/scp.c: In function ‘lostconn’:
src/scp.c:1255:17: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 1255 |                 write(STDERR_FILENO, "lost connection\n", 16);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I guess this compile path hasn't been tested recently.

Platform is Ubuntu 24.04, compiler: gcc version 13.3.0 (Ubuntu 13.3.0-6ubuntu2~24.04)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions