Skip to content

Upgrade to Spring Boot 3.4 #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2025
Merged

Upgrade to Spring Boot 3.4 #150

merged 1 commit into from
Jan 9, 2025

Conversation

bjansen
Copy link
Contributor

@bjansen bjansen commented Dec 11, 2024

This fixes the following error when upgrading a project that uses Charon to Spring Boot 3.4:

java.lang.AbstractMethodError: Receiver class com.github.mkopylec.charon.forwarding.interceptors.HttpRequest does not define or inherit an implementation of the resolved method 'abstract java.util.Map getAttributes()' of interface org.springframework.http.HttpRequest.

@bjansen
Copy link
Contributor Author

bjansen commented Dec 11, 2024

I didn't add any tests because it's "just" new getters, but let me know if you'd like coverage on these.

@bjansen
Copy link
Contributor Author

bjansen commented Jan 7, 2025

@mkopylec could you have a look at this PR please?

@andrewtaylor andrewtaylor mentioned this pull request Jan 7, 2025
Closed
@mkopylec mkopylec merged commit ec2b68e into mkopylec:master Jan 9, 2025
1 check failed
@mkopylec
Copy link
Owner

mkopylec commented Jan 9, 2025

Released in 5.4.0.

@bjansen
Copy link
Contributor Author

bjansen commented Jan 9, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkopylec mkopylec mkopylec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjansen @mkopylec