You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/PULL_REQUEST_TEMPLATE.md
+3-8Lines changed: 3 additions & 8 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -9,12 +9,7 @@ I'm making a Pull Request(PR). Please see the details below.
9
9
10
10
**A good PR 🌟**
11
11
12
-
### → Step 1: Which branch are you submitting to? 🌲
13
-
> Development (for new features or updates), Release (for bug fixes), or ___________?
14
-
15
-
16
-
17
-
### → Step 2: Describe your Pull Request 📝
12
+
### → Step 1: Describe your Pull Request 📝
18
13
> Fixing a Bug? Adding an Update? Submitting a New Feature? Does it introduce a breaking change?
19
14
20
15
@@ -23,15 +18,15 @@ I'm making a Pull Request(PR). Please see the details below.
23
18
24
19
**A great PR 🌟🌟**
25
20
26
-
### → Step 3: Share a Relevant Example 🦄
21
+
### → Step 2: Share a Relevant Example 🦄
27
22
> Here's some example code or a demonstration of my feature as a part of this pull request, a separate pull request, in the https://editor.p5js.org, or codepen/jsfiddle/etc...
28
23
29
24
30
25
31
26
32
27
**The best PR 🌟🌟🌟**
33
28
34
-
### → Step 4: Screenshots or Relevant Documentation 🖼
29
+
### → Step 3: Screenshots or Relevant Documentation 🖼
35
30
> Here's some helpful screenshots and/or documentation of the new feature
Copy file name to clipboardExpand all lines: CODE_OF_CONDUCT.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -41,7 +41,7 @@ We like these hashtags: #noCodeSnobs (because we value community over efficiency
41
41
42
42
Our community is always looking for enthusiasts to help in all different ways.
43
43
44
-
-**Develop**. [GitHub](https://github.com/ml5js/ml5-library) is the main place where code is collected, issues are documented, and discussions about code are had. Check out the [contributing documentation to get started](https://github.com/ml5js/ml5-library/blob/development/CONTRIBUTING.md) with developing the library.
44
+
-**Develop**. [GitHub](https://github.com/ml5js/ml5-library) is the main place where code is collected, issues are documented, and discussions about code are had. Check out the [contributing documentation to get started](https://github.com/ml5js/ml5-library/blob/main/CONTRIBUTING.md) with developing the library.
45
45
-**Document**. Everyone loves documentation. Help is needed porting examples, and adding documentation, and creating tutorials.
46
46
-**Teach**. Teach a workshop, a class, a friend, a collaborator! Tag [@ml5js on Twitter](https://twitter.com/ml5js?lang=en) and we will do our best to share what you're doing.
47
47
-**Create**. ml5.js is looking for designers, artists, coders, programmers to bring your creative and amazing work to show and inspire other people. Submit your work to [email protected].
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+8-8Lines changed: 8 additions & 8 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -37,8 +37,8 @@ Preamble: If you're interested in to contribute to the ml5 project, just know yo
37
37
3. you make a comment on an existing issue or post your issue and indicate that you're curious to do your best to solve it 🔬
38
38
4. you create a new branch on your `forked` copy of the ml5-library and call it something meaningful like `fix-detection-results`
39
39
5. you jam on fixing the bug, commit your changes with meaningful commit messages, and push your changes to your bug fix branch (e.g. `fix-detection-results`)
40
-
6. when ready, make a pull request to the `release` branch or `development` branch of ml5-library. Submit to the `release` branch if the bug you found was in the current ml5 release - the version of ml5 which is on npm. Submit to the `development` branch if the bug you found was in `development` branch of ml5-library.
41
-
7. the ml5 dev team will review your changes and quite likely correspond with you on your changes. When all looks good, your changes will be merged in. 🎉
40
+
6. when ready, make a pull request to the `main` branch of ml5-library. Prepend "[NEEDS RELEASE]" to the title if the bug you found was in the current ml5 release - the version of ml5 which is on npm.
41
+
7. the ml5 dev team will review your changes and quite likely correspond with you on your changes. When all looks good, a `ready for release` label will be added to your PR and your changes will be merged in and release with the next public update to the library. 🎉
42
42
8. hi-fives 👏 and hugs 🤗
43
43
44
44
### For new features or feature additions/updates
@@ -48,7 +48,7 @@ Preamble: If you're interested in to contribute to the ml5 project, just know yo
48
48
4. you create a new branch on your `forked` copy of the ml5-library and call it something meaningful like `new-generative-model-x`
49
49
5. you jam on your new feature, commit your changes with meaningful commit messages, and push your changes to your new feature branch (e.g. `new-generative-model-x`)
50
50
6. you should also add an example of your new feature to the `examples/` directory so that other people can learn how to use your new feature.
51
-
7. when ready, make a pull request to the `development` branch of ml5-library. Submit to the `development` since your feature is part of the new frontier of the ml5-library.
51
+
7. when ready, make a pull request to the `main` branch of ml5-library.
52
52
8. the ml5 dev team will review your changes and quite likely correspond with you on your changes. When all looks good, your changes will be merged in. 🎉
This creates a new folder called `/manual-test` in the project's root folder. Create an `index.html` file inside `/manual-test` and add the following:
171
+
This creates a new folder called `/manual-test` in the project's root folder. The `/manual-test` folder contains an `index.html` file with the following content:
@@ -254,6 +252,8 @@ This last one is case sensitive!
254
252
255
253
## Making Releases (For the ml5 core team)
256
254
255
+
**NOTE: This section needs to be updated to align with the new `main` branch structure.**
256
+
257
257
Work in progress - we are working on making a few scripts to make it easier to make releases and deployments. For now, to address the long-winded process noted in https://github.com/ml5js/ml5-library/issues/387, we are experimenting with some devOps scripts.
258
258
259
259
In the instance you're ready to make a new release from `development` to `release`:
You can find a collection of standalone examples in this repository within the `examples/` directory. You can also test working hosted of the examples online on the ml5.js examples index website (TODO: Add a link).
76
+
You can find a collection of standalone examples in this repository within the `examples/` directory. You can also test working hosted of the examples online on the [ml5.js examples index website](https://examples.ml5js.org/).
80
77
81
78
These examples are meant to serve as an introduction to the library and machine learning concepts.
Copy file name to clipboardExpand all lines: docs/faq.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -6,7 +6,7 @@ Mostly.
6
6
7
7
A number of the ml5 sketches don't currently work in the p5 web editor due to some of the ways that the editor handles data files and some of the network communication regarding making requests to external data (e.g. the big model files that allow ml5.js to run things like image detection, etc).
8
8
9
-
There are lots of developments in the p5 web editor as well as in ml5 to make sure these environments all play nicely together. If something doesn't work in the web editor, the best thing to do is to try and run things locally if possible. See [running a local web server tutorial](/docs/tutorials/local-web-server.md).
9
+
There are lots of developments in the p5 web editor as well as in ml5 to make sure these environments all play nicely together. If something doesn't work in the web editor, the best thing to do is to try and run things locally if possible. See [running a local web server tutorial](/tutorials/local-web-server.md).
10
10
11
11
Thanks!
12
12
@@ -28,4 +28,4 @@ Please contact us at [@ml5js on twitter](https://twitter.com/ml5js), <a href="ma
28
28
29
29
### How can I contribute?
30
30
31
-
Please refer to the contributor documentation [on Github](https://github.com/ml5js/ml5-library/blob/development/CONTRIBUTING.md).
31
+
Please refer to the contributor documentation [on Github](https://github.com/ml5js/ml5-library/blob/main/CONTRIBUTING.md).
Copy file name to clipboardExpand all lines: docs/reference/charrnn.md
+7-7Lines changed: 7 additions & 7 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -10,7 +10,7 @@
10
10
11
11
RNN and LSTMs (Long Short Term Memory networks) are a type of Neural Network architecture useful for working with sequential data (like characters in text or the musical notes of a song) where the order of the that sequence matters. This class allows you run a model pre-trained on a body of text to generate new text.
12
12
13
-
You can train your own models using this tutorial or use this set of pretrained models.
13
+
You can train your own models [following the instructions in the training-charRNN repo](https://github.com/ml5js/training-charRNN). There is also a selection of [pre-trained model examples available](https://github.com/ml5js/ml5-data-and-models/tree/main/models/charRNN).
0 commit comments